-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add package dependencies #911
Merged
joseivanlopez
merged 9 commits into
agama-project:master
from
joseivanlopez:dependencies
Dec 5, 2023
Merged
Add package dependencies #911
joseivanlopez
merged 9 commits into
agama-project:master
from
joseivanlopez:dependencies
Dec 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseivanlopez
force-pushed
the
dependencies
branch
from
December 5, 2023 08:49
ccb3f34
to
b0ab5a6
Compare
imobachgs
reviewed
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I only have two comments but, otherwise, it looks great.
imobachgs
approved these changes
Dec 5, 2023
imobachgs
approved these changes
Dec 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
From time to time an issue is reported because some missing dependency in the Agama live image (many times related to missing storage packages). Moreover, Agama depencencies are directly added to the ISO kiwi file, forcing to all our live images to include that list of packages. Agama should requires its own dependencies instead on relying on the live iso to provide them.
Solution
setup
scripts.Notes:
setup
scripts and the spec files contain almost the same list of packages. They should be unified.