Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the repo structure to handle multiple project #76

Merged

Conversation

Francois-Werbrouck
Copy link
Contributor

ref #68

@Francois-Werbrouck Francois-Werbrouck self-assigned this Jul 17, 2024
@Francois-Werbrouck Francois-Werbrouck linked an issue Jul 17, 2024 that may be closed by this pull request
@Francois-Werbrouck
Copy link
Contributor Author

Hi @sylvanie85 and @k-allagbe, I've refactor the structure of the Datastore and updated the documentation. Let me know what you think of it.

@Francois-Werbrouck
Copy link
Contributor Author

We also need to update the Backend of Nachet because I've removed the default value given to parameters in few functions.

@Francois-Werbrouck
Copy link
Contributor Author

I have updated the Pyproject, however, I'm quite unsure about how they work.

@k-allagbe
Copy link
Member

I have updated the Pyproject, however, I'm quite unsure about how they work.

I'm not either. Checkout the structure in https://github.com/ai-cfia/azure-db where each folder (package) has it's own setup.py. And for the installation in the finesse-backend/requirements.txt, I used:

git+https://github.com/ai-cfia/azure-db.git@main#subdirectory=azure-ai-search

This would work okay. If we want to version each package individually though, I don't know any way other than separate them in their own repo.

Please @ai-cfia/devops, give your opinions.

Copy link
Contributor

@sylvanie85 sylvanie85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I'll create an issue on backend to update it, let me know when you think it's done I'll be able to test if everything is still working before your merge

Edit :
ai-cfia/nachet-backend#107

@Francois-Werbrouck Francois-Werbrouck force-pushed the 68-update-the-repo-structure-to-handle-multiple-project branch from 0bb7c08 to 237228f Compare July 18, 2024 14:33
@Francois-Werbrouck Francois-Werbrouck marked this pull request as ready for review July 18, 2024 14:45
Copy link
Contributor

@sylvanie85 sylvanie85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, everything is working on nachet (just need to merge ai-cfia/nachet-backend#108)
well done! 🤠

@Francois-Werbrouck
Copy link
Contributor Author

image
as shown, all tests are passing. However, the workflow needs to be updated I think to search only for 'test_*.py'

@Francois-Werbrouck Francois-Werbrouck merged commit d397464 into main Jul 25, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the repo structure to handle multiple project
3 participants