-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the repo structure to handle multiple project #76
Update the repo structure to handle multiple project #76
Conversation
Hi @sylvanie85 and @k-allagbe, I've refactor the structure of the Datastore and updated the documentation. Let me know what you think of it. |
We also need to update the Backend of Nachet because I've removed the default value given to parameters in few functions. |
I have updated the Pyproject, however, I'm quite unsure about how they work. |
I'm not either. Checkout the structure in https://github.com/ai-cfia/azure-db where each folder (package) has it's own
This would work okay. If we want to version each package individually though, I don't know any way other than separate them in their own repo. Please @ai-cfia/devops, give your opinions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'll create an issue on backend to update it, let me know when you think it's done I'll be able to test if everything is still working before your merge
Edit :
ai-cfia/nachet-backend#107
0bb7c08
to
237228f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, everything is working on nachet (just need to merge ai-cfia/nachet-backend#108)
well done! 🤠
ref #68