Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #46: update search sources #49

Merged
merged 15 commits into from
Dec 11, 2023
Merged

Conversation

k-allagbe
Copy link
Member

@k-allagbe k-allagbe commented Nov 29, 2023

Closes #46
Closes #13

  • update debug panel
  • integrate azure search
  • handle azure hit highlighting
  • fix backend ping
  • fix debug panel position when there is no warning
  • manual tests
  • automated tests
  • update version
  • documentation
  • manual test documentation

@k-allagbe k-allagbe self-assigned this Nov 29, 2023
@k-allagbe k-allagbe marked this pull request as draft November 29, 2023 14:05
@k-allagbe k-allagbe force-pushed the k-allagbe/issue46-handle-azure-db branch from af79f11 to 4d56d03 Compare November 29, 2023 14:18
@k-allagbe k-allagbe requested a review from CFIALeronB November 29, 2023 14:21
@rngadam
Copy link
Contributor

rngadam commented Nov 29, 2023

don't forget to provide before and after screenshots

@k-allagbe k-allagbe marked this pull request as ready for review November 29, 2023 19:08
@k-allagbe k-allagbe requested a review from rngadam November 29, 2023 19:08
@k-allagbe
Copy link
Member Author

k-allagbe commented Nov 29, 2023

don't forget to provide before and after screenshots

Before:
image

image

After:
image

image

Copy link
Contributor

@rngadam rngadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add tasks for documentation, automated testing, versioning (_versions.ts) and documenting the manual tests as per:

ai-cfia/nachet-frontend#72

Copy link
Contributor

@CFIALeronB CFIALeronB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k-allagbe New Debug Panel looks good! Only issue I found durring testing is that static results were not populated once the user selects a static response option:

image
image

@k-allagbe
Copy link
Member Author

@k-allagbe New Debug Panel looks good! Only issue I found durring testing is that static results were not populated once the user selects a static response option:

image image

This is probably because your instance was not pointing on a finesse-backend. Make sure finesse-backend is running and the env var is pointing to it.

@k-allagbe k-allagbe force-pushed the k-allagbe/issue46-handle-azure-db branch from 0c021d2 to 46b32da Compare December 1, 2023 23:01
@k-allagbe k-allagbe force-pushed the k-allagbe/issue46-handle-azure-db branch from 46b32da to 490292b Compare December 1, 2023 23:26
@vivalareda vivalareda force-pushed the k-allagbe/issue46-handle-azure-db branch from 5784a2f to da8c71d Compare December 6, 2023 16:26
@vivalareda vivalareda force-pushed the k-allagbe/issue46-handle-azure-db branch from 2b2f999 to 22db4e0 Compare December 8, 2023 13:24
@vivalareda vivalareda force-pushed the k-allagbe/issue46-handle-azure-db branch from 41b42eb to 283d5a3 Compare December 8, 2023 14:55
@vivalareda
Copy link
Contributor

Sorry for amount of deployment messages but I had test a lot to figure out a fix. I changed the reusable workflow to install the npm version used in the lint-test and required from the package.json's engines

@k-allagbe
Copy link
Member Author

k-allagbe commented Dec 8, 2023

Sorry for amount of deployment messages but I had test a lot to figure out a fix. I changed the reusable workflow to install the npm version used in the lint-test and required from the package.json's engines

I would suggest adding the ability to pass the versions as parameter if possible in all related reusable workflows to avoid any future discrepancy. @rngadam ?

@vivalareda
Copy link
Contributor

Sorry for amount of deployment messages but I had test a lot to figure out a fix. I changed the reusable workflow to install the npm version used in the lint-test and required from the package.json's engines

I would suggest adding the ability to pass the versions as parameter if possible in all related reusable workflows to avoid any future discrepancy.

Sorry for amount of deployment messages but I had test a lot to figure out a fix. I changed the reusable workflow to install the npm version used in the lint-test and required from the package.json's engines

I would suggest adding the ability to pass the versions as parameter if possible in all related reusable workflows to avoid any future discrepancy.

Should be checked with Ricky since version is hardcoded in lint-test maybe it's for consistency across the repositories but it can be added forsure

@k-allagbe k-allagbe merged commit fd03251 into main Dec 11, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants