-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue #46: update search sources #49
Conversation
af79f11
to
4d56d03
Compare
don't forget to provide before and after screenshots |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add tasks for documentation, automated testing, versioning (_versions.ts) and documenting the manual tests as per:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@k-allagbe New Debug Panel looks good! Only issue I found durring testing is that static results were not populated once the user selects a static response option:
This is probably because your instance was not pointing on a finesse-backend. Make sure finesse-backend is running and the env var is pointing to it. |
0c021d2
to
46b32da
Compare
46b32da
to
490292b
Compare
5784a2f
to
da8c71d
Compare
2b2f999
to
22db4e0
Compare
41b42eb
to
283d5a3
Compare
Sorry for amount of deployment messages but I had test a lot to figure out a fix. I changed the reusable workflow to install the npm version used in the lint-test and required from the package.json's engines |
I would suggest adding the ability to pass the versions as parameter if possible in all related reusable workflows to avoid any future discrepancy. @rngadam ? |
Should be checked with Ricky since version is hardcoded in lint-test maybe it's for consistency across the repositories but it can be added forsure |
Closes #46
Closes #13