Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K-allagbe/issue16-greyed-out-query #61

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

k-allagbe
Copy link
Member

Closes #16: query becomes a placeholder after submit

  • dissociate query from searchbar placeholder
  • manual tests
  • automated tests
  • version update

Sorry, something went wrong.

@rngadam
Copy link
Contributor

rngadam commented Dec 14, 2023

Anytime changes are made to the frontend behavior, a quick videocap or screenshots should be archived as part of the PR to understand the before and after change (and figuring out if this change solves the original issue).

@rngadam
Copy link
Contributor

rngadam commented Dec 14, 2023

Tried to use the deployed dev version https://finesse-frontend-dev.vercel.app/search but I'm not getting any results from either AI lab or Microsoft search

@k-allagbe
Copy link
Member Author

k-allagbe commented Dec 14, 2023

Tried to use the deployed dev version https://finesse-frontend-dev.vercel.app/search but I'm not getting any results from either AI lab or Microsoft search

Strange, because I'm getting the results.

image

@k-allagbe k-allagbe merged commit b9f0a66 into main Dec 14, 2023
5 checks passed
@k-allagbe k-allagbe mentioned this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query is greyed out and cannot be further edited, once we hit enter to search. (version v0.1.0)
2 participants