Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #89: Fix markdown check not working properly #111

Conversation

SonOfLope
Copy link
Contributor

@SonOfLope SonOfLope commented Apr 4, 2024

This pull request provides hotfix for the markdown lint workflow that wasnt working at all. The default configuration of the GH action only checks for markdown files at root directory. The hotfix enables validation recursively in all folders.

Also :

  • add config file to disable line length on headers, code blocks and tables

  • Resolve markdown violations that were not detected before hotfix

  • disable autofix

  • Update yaml lint workflow to reflect solution to keep standard (for optional config file applying to workflow)

  • enable a config file path parameter for both dead links action and markdown lint action.

Repositories that will need to be updated after this merge since they use custom config files:

@SonOfLope SonOfLope mentioned this pull request Apr 5, 2024
3 tasks
@rngadam rngadam changed the title Issue #89: Fix mardown check not working properly Issue #89: Fix markdown check not working properly Apr 5, 2024
Copy link
Contributor

@rngadam rngadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG

@SonOfLope SonOfLope merged commit 19309d6 into main Apr 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix option to markdown check does nothing and may be hiding actual errors?
2 participants