-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue #51: implement pipeline switching in back end #55
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have missing EOF newline. please add
please add
to your repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed yesterday, the code here does not seem to be going in the right direction in terms of readability, testability and simplicity
efd2bfe
to
44a3227
Compare
I've added model documentation from the backend. It is still a work in progress. Following this doc, here is a list of what's left to do in the code:
I'm asking for reviews from:
To access the new documentation: docs/nachet-model-documentation.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have a number of lint failures reported from the Github Workflows.
Suggest managing your TODO list as a checklist in the description of this pull request (it's easy to lose track in the comments of the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's still basic issues with EOF newline missing so looks like the Github workflows are not all running.
@MaxenceGui Modify the description to add checklist items as completed by referencing postponed tasks to new issues; this gives us a trace between the work that should have been done here and follow up issues. |
Perfect, will do that. I push my last commit so all checks pass. @RussellJimmies and @rngadam if there is any last-minute review you wanna add, go ahead. If you approve this PR I will rebase and push it to main. |
Seems like the issue links are created manually in the description? I think they look nicer if you use this notation:
output: |
It is I will absolutely change it |
fixes #51: Move insert_new_version_pipeline to pipelines_version_insertion.py
fixes #51: Refactor model folder
issue #51: change mermaid theme
Update CODEOWNERS file Update CODEOWNERS file
* # fixes #64: Add MAX_CONTENT_LENGTH env * fixes #64 Add devSecOps variable name * fixes #64: fix typo * Update README.md Co-authored-by: Jonathan Lopez <[email protected]> * Update .env.template Co-authored-by: Jonathan Lopez <[email protected]> * isssue #64: Get rid of eval --------- Co-authored-by: Jonathan Lopez <[email protected]> fixes #51: connecting to swin model fixes #51: refactor exception fixes #51: add request_factory function to bring a standard to call model fixes #51: add models_Utils.py fixes #51: Update model_utilitary_functions import fixes #51: update result parsing and add default pipeline fixes #51: update inference_request to call swin in loop fixes #51: Standardize headers with azureml-model-deployment being mandantory fixes #51: correct failed check from workflows fixes #51: Refactor inference result processing and add test file for inference request fixes #51: Change the categories model name fixes #51: implement model module request inference function fixes #51: add function to retrieve pipeline info from blob storage fixes #51: Add script to upload to blob storage json file containing pipeline fixes #51: correct lint error Update nachet-inference-documentation.md to reflect code change fixes #51: Update sequence diagram fixes #51: update README and TESTING fixes #51: correcting markdown lint fixes #51: Add inference request test fixes #51: inference test with Quart.test_client fixes #51: Correct lint ruff error and tests fixes #51: implement Ricky reviews Update CODEOWNERS file Update CODEOWNERS file fixes #64: Increase MAX_CONTENT_LENGTH (#66) * # fixes #64: Add MAX_CONTENT_LENGTH env * fixes #64 Add devSecOps variable name * fixes #64: fix typo * Update README.md Co-authored-by: Jonathan Lopez <[email protected]> * Update .env.template Co-authored-by: Jonathan Lopez <[email protected]> * isssue #64: Get rid of eval --------- Co-authored-by: Jonathan Lopez <[email protected]>
issue #51: Modify documentation to reflect change on Model namedtuple
* Update Sequence Diagram README.md ![SD_1 drawio (2)](https://github.com/ai-cfia/nachet-backend/assets/19809069/272f37dc-f4ec-449b-ba82-950c54b9f856) issue #51: Fixing Markdown lint issue #51: fixing MD lint
2aee94c
to
d9ffdfb
Compare
@RussellJimmies just missing your approval before merging in with main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gargantuan work, great job! Code LGTM.
Co-authored-by: William Lemire <[email protected]>
Co-authored-by: William Lemire <[email protected]>
Co-authored-by: William Lemire <[email protected]>
Co-authored-by: William Lemire <[email protected]>
Implement model categories with their task (Classification, Object detection, Segmentation)