-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pytest to run Python bindings tests #70
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I imagine you won't be able to refactor all the tests in one go, so that there will be some unittest
and some pytest
cases. I think with dynamic test discovery you can probably run unittest
and pytest
back to back.
And, the build-test-python
action still uses unittest, so when you start refactoring to use pytest
you won't see the results in the CI. I think this would be a good place to also invoke pytest
in that CI action. At the end of the test refactor you can then remove the unittest
calls entirely.
Edit: as mentioned in the original issue #69, pytest
will already discover and run unittest
tests, so it's not necessary to invoke the test runner twice. Still, the CI should be updated.
Thanks for thinking about the CI.
|
I think, given the very minor change to the base Dockerfile, I agree with manually building it from this branch. That way we don't have to remember to remove that line in a future step. If you do that, I would wait to close this PR until the image is built and the CI passes again. |
adcae4e
to
542d95e
Compare
Description
This PR solves the issue by installing pytest and running the tests with it. Low risk change here that simply enables easier tests for the future
Review guidelines
Estimated Time of Review: 2 minutes