Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to be compatible with pyfirecreset v2.6.0 #36

Merged
merged 39 commits into from
Jul 30, 2024

change from random to itertools

7254af5
Select commit
Loading
Failed to load commit list.
Merged

Upgrade to be compatible with pyfirecreset v2.6.0 #36

change from random to itertools
7254af5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 30, 2024 in 0s

79.94% (target 75.00%)

View this Pull Request on Codecov

79.94% (target 75.00%)

Details

Codecov Report

Attention: Patch coverage is 79.17808% with 76 lines in your changes missing coverage. Please review.

Project coverage is 79.94%. Comparing base (eb7f751) to head (7254af5).

Files Patch % Lines
aiida_firecrest/transport.py 82.25% 55 Missing ⚠️
aiida_firecrest/scheduler.py 61.81% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   76.25%   79.94%   +3.68%     
==========================================
  Files           6        4       -2     
  Lines        1057      678     -379     
==========================================
- Hits          806      542     -264     
+ Misses        251      136     -115     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.