Make commits count as default for preview #255
Conversation
|
|
Thanks @unkcpz for giving me the chance to write my first ever code review!😅 The sorting process that happens in |
|
Thanks @AhmedBasem20, I have no idea how to do this "simple" task 😸 . Can you help me by point me to where is the code I need to look? |
|
Sorry @unkcpz I just was trying to comment on the code part that needs to be changed but didn't figure out how :D |
That's better! Looks like an easy peasy for you.
You can goto the source code and select multiple lines, then there will be a "..." on the left. Click it and you can copy the premalink, paste to the comment and the code will show.
|
Nice tip! The preview looks good this can be merged now. |
|
Thanks a lot! Now I see how |
We execute the sort by commits when the page is loaded, to achieve that we use `useEffect` hook that runs a specified effect immediately after rendering the page. --------- Co-authored-by: Ahmed Basem <[email protected]>
We execute the sort by commits when the page is loaded, to achieve that we use `useEffect` hook that runs a specified effect immediately after rendering the page. --------- Co-authored-by: Ahmed Basem <[email protected]>
We execute the sort by commits when the page is loaded, to achieve that we use `useEffect` hook that runs a specified effect immediately after rendering the page. --------- Co-authored-by: Ahmed Basem <[email protected]>
We execute the sort by commits when the page is loaded, to achieve that we use `useEffect` hook that runs a specified effect immediately after rendering the page. --------- Co-authored-by: Ahmed Basem <[email protected]>
We execute the sort by commits when the page is loaded, to achieve that we use `useEffect` hook that runs a specified effect immediately after rendering the page. --------- Co-authored-by: Ahmed Basem <[email protected]>
We execute the sort by commits when the page is loaded, to achieve that we use `useEffect` hook that runs a specified effect immediately after rendering the page. --------- Co-authored-by: Ahmed Basem <[email protected]>
We execute the sort by commits when the page is loaded, to achieve that we use `useEffect` hook that runs a specified effect immediately after rendering the page. --------- Co-authored-by: Ahmed Basem <[email protected]>
We execute the sort by commits when the page is loaded, to achieve that we use `useEffect` hook that runs a specified effect immediately after rendering the page. --------- Co-authored-by: Ahmed Basem <[email protected]>
We execute the sort by commits when the page is loaded, to achieve that we use `useEffect` hook that runs a specified effect immediately after rendering the page. --------- Co-authored-by: Ahmed Basem <[email protected]>
We execute the sort by commits when the page is loaded, to achieve that we use `useEffect` hook that runs a specified effect immediately after rendering the page. --------- Co-authored-by: Ahmed Basem <[email protected]>
For the internal team review, I suggest using the "commits count" order as a default, we can decide which metric to use after the release sort information is added.