Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark for sending large WebSocket messages #9635

Merged
merged 5 commits into from
Nov 3, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 3, 2024

SSIA

For validating if #9634 is a good idea or not

@bdraco bdraco requested a review from asvetlov as a code owner November 3, 2024 02:09
@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Nov 3, 2024
Copy link

codspeed-hq bot commented Nov 3, 2024

CodSpeed Performance Report

Merging #9635 will not alter performance

Comparing large_websocket_messages (70fc69e) with master (c95c025)

Summary

✅ 8 untouched benchmarks

🆕 1 new benchmarks

Benchmarks breakdown

Benchmark master large_websocket_messages Change
🆕 test_send_one_hundred_large_websocket_text_messages[pyloop] N/A 664.6 µs N/A

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.64%. Comparing base (c95c025) to head (70fc69e).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #9635   +/-   ##
=======================================
  Coverage   98.64%   98.64%           
=======================================
  Files         114      114           
  Lines       35361    35372   +11     
  Branches     4191     4193    +2     
=======================================
+ Hits        34882    34893   +11     
  Misses        321      321           
  Partials      158      158           
Flag Coverage Δ
CI-GHA 98.52% <100.00%> (+<0.01%) ⬆️
OS-Linux 98.20% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.10% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.41% <100.00%> (-0.01%) ⬇️
Py-3.10.11 97.27% <100.00%> (+<0.01%) ⬆️
Py-3.10.15 97.68% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 97.75% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.35% <100.00%> (-0.01%) ⬇️
Py-3.12.7 98.23% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 98.22% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.18% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 97.59% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 97.21% <100.00%> (+<0.01%) ⬆️
VM-macos 97.41% <100.00%> (-0.01%) ⬇️
VM-ubuntu 98.20% <100.00%> (+<0.01%) ⬆️
VM-windows 96.10% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco enabled auto-merge (squash) November 3, 2024 03:06
@bdraco bdraco merged commit 23d2966 into master Nov 3, 2024
38 of 39 checks passed
@bdraco bdraco deleted the large_websocket_messages branch November 3, 2024 03:32
Copy link
Contributor

patchback bot commented Nov 3, 2024

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/23d2966b20275c8182ffd4d883d9218653591fdf/pr-9635

Backported as #9638

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 3, 2024
Copy link
Contributor

patchback bot commented Nov 3, 2024

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/23d2966b20275c8182ffd4d883d9218653591fdf/pr-9635

Backported as #9639

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 3, 2024
bdraco added a commit that referenced this pull request Nov 3, 2024
bdraco added a commit that referenced this pull request Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant