Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9635/23d2966b backport][3.11] Add benchmark for sending large WebSocket messages #9639

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Nov 3, 2024

This is a backport of PR #9635 as merged into master (23d2966).

SSIA

For validating if #9634 is a good idea or not

@bdraco bdraco enabled auto-merge (squash) November 3, 2024 03:33
Copy link

codspeed-hq bot commented Nov 3, 2024

CodSpeed Performance Report

Merging #9639 will not alter performance

Comparing patchback/backports/3.11/23d2966b20275c8182ffd4d883d9218653591fdf/pr-9635 (2684479) with 3.11 (594ceaf)

Summary

✅ 8 untouched benchmarks

🆕 1 new benchmarks

Benchmarks breakdown

Benchmark 3.11 patchback/backports/3.11/23d2966b20275c8182ffd4d883d9218653591fdf/pr-9635 Change
🆕 test_send_one_hundred_large_websocket_text_messages[pyloop] N/A 665.2 µs N/A

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.88%. Comparing base (e503f7a) to head (2684479).
Report is 2 commits behind head on 3.11.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.11    #9639   +/-   ##
=======================================
  Coverage   97.88%   97.88%           
=======================================
  Files         115      115           
  Lines       35436    35447   +11     
  Branches     4244     4246    +2     
=======================================
+ Hits        34688    34699   +11     
  Misses        559      559           
  Partials      189      189           
Flag Coverage Δ
CI-GHA 97.77% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.46% <100.00%> (+<0.01%) ⬆️
OS-Windows 94.38% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.69% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 96.55% <100.00%> (-0.01%) ⬇️
Py-3.10.15 96.96% <100.00%> (+<0.01%) ⬆️
Py-3.11.10 97.03% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 96.63% <100.00%> (-0.01%) ⬇️
Py-3.12.7 97.50% <100.00%> (+<0.01%) ⬆️
Py-3.13.0 97.49% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 96.47% <100.00%> (+<0.01%) ⬆️
Py-3.9.20 96.88% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 96.48% <100.00%> (+<0.01%) ⬆️
VM-macos 96.69% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.46% <100.00%> (+<0.01%) ⬆️
VM-windows 94.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit ef53ab1 into 3.11 Nov 3, 2024
34 of 35 checks passed
@bdraco bdraco deleted the patchback/backports/3.11/23d2966b20275c8182ffd4d883d9218653591fdf/pr-9635 branch November 3, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant