Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TypeScript and VSCode dependencies #217

Closed
wants to merge 1 commit into from

Conversation

aioutecism
Copy link
Owner

No description provided.

@alisonatwork
Copy link
Collaborator

@aioutecism while i was playing around with trying to improve the speed of the tests, i tried to bump the various versions of dependencies based on your changes on this PR. My package.json looks like this:

--- a/package.json
+++ b/package.json
@@ -33,7 +33,7 @@
     "engines": {
         "node": "^8.6.0",
         "npm": "^5.6.0",
-        "vscode": "^1.19.0"
+        "vscode": "^1.32.0"
     },
     "main": "./out/src/extension",
     "extensionKind": [
@@ -258,14 +258,17 @@
         "prettier-write": "prettier --write '{src,test}/**/*.ts'"
     },
     "devDependencies": {
-        "@types/mocha": "^5.2.0",
-        "@types/node": "^8.6.0",
-        "@types/vscode": "^1.19.0",
+        "@types/glob": "^7.1.1",
+        "@types/mocha": "^5.2.6",
+        "@types/node": "^8.10.25",
+        "@types/vscode": "^1.32.0",
         "github-releases-renderer": "github:aioutecism/github-releases-renderer",
-        "mocha": "^5.1.1",
+        "glob": "^7.1.4",
+        "mocha": "^6.1.4",
         "prettier": "^1.19.1",
-        "rimraf": "^2.6.2",
-        "typescript": "^2.8.3",
+        "rimraf": "^2.7.1",
+        "source-map-support": "^0.5.12",
+        "typescript": "^3.5.1",
         "vscode-test": "^1.3.0"
     },
     "dependencies": {}

Everything worked fine with the newer Typescript, so i think it's reasonable to go ahead with this upgrade.

@aioutecism
Copy link
Owner Author

@alisonatwork Thanks! Just checked Breaking Changes and everything seems fine. Why don't we update to the latest TS 3.7.3?
And could you please create another PR with your changes?

@alisonatwork
Copy link
Collaborator

The changes I currently have are on top of the changes inside #258 which makes it a bit tricky. Let me try to put together a PR that just includes the dependency changes, hang on...

@alisonatwork
Copy link
Collaborator

Here is the new PR for upgrading dependencies: #259 That includes the same changes as this one, plus the change to vscode-test (from vscode) for the latest test harness code.

@alisonatwork
Copy link
Collaborator

These changes merged in #259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants