Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Jira: Fixed aggregatetimeoriginalestimate, timeoriginalestimate field types for the Issues stream schema #31385

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

bazarnov
Copy link
Collaborator

What

Based on this test: https://storage.cloud.google.com/airbyte-ci-reports-multi/airbyte-ci/connectors/test/nightly_builds/master/1697156217/c4ff29e23abdb30ed173d0b12709281632f5ea18/source-jira/0.9.0/output.html

Need to:

  • update the schema for the Issues stream
  • update expected records

How

  • changed the type for aggregatetimeoriginalestimate, timeoriginalestimate fields for the Issues stream schema, from array and int >>> string and string accordingly.
  • updated expected records.jsonl

🚨 User Impact 🚨

After the update, the users of the Issues stream should reset the stream and make a full-refresh once again, because of the schema change for the single stream.

@vercel
Copy link

vercel bot commented Oct 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2023 0:40am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@airbyte-oss-build-runner
Copy link
Collaborator

source-jira test report (commit 8212d7562f) - ✅

⏲️ Total pipeline duration: 09mn58s

Step Result
Build source-jira docker image for platform(s) linux/x86_64
Unit tests
Integration tests
Acceptance tests
Code format checks
Validate metadata for source-jira
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-jira test

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Oct 13, 2023
@bazarnov bazarnov merged commit 4308255 into master Oct 13, 2023
27 of 28 checks passed
@bazarnov bazarnov deleted the baz/source-jira/fix-issues-schema branch October 13, 2023 13:07
ariesgun pushed a commit to ariesgun/airbyte that referenced this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/jira team/connectors-python
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants