Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 Source Gitlab: certification improvements: epics pk, date-time format, docs, allowed hosts #31700

Merged
merged 11 commits into from
Oct 26, 2023

Conversation

darynaishchenko
Copy link
Collaborator

@darynaishchenko darynaishchenko commented Oct 23, 2023

What

  • deployments, groups_members and projects_members have incorrect date format instead of date-time
  • docs have optional fields in Prerequisites section, and type in api url description
  • allowed hosts in metadata must be restrict

How

  • fixed format
  • removed optional from Prerequisites and fixed typo
  • updated allowed hosts to use api url from config

@darynaishchenko darynaishchenko self-assigned this Oct 23, 2023
@vercel
Copy link

vercel bot commented Oct 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Oct 26, 2023 2:33pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/gitlab labels Oct 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@airbyte-oss-build-runner
Copy link
Collaborator

source-gitlab test report (commit 0f3590fce0) - ✅

⏲️ Total pipeline duration: 12mn11s

Step Result
Build source-gitlab docker image for platform(s) linux/amd64
Unit tests
Acceptance tests
Check our base image is used
Code format checks
Validate metadata for source-gitlab
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-gitlab test

@octavia-squidington-iv octavia-squidington-iv requested a review from a team October 23, 2023 10:33
@octavia-squidington-iv octavia-squidington-iv requested a review from a team October 23, 2023 10:57
@airbyte-oss-build-runner
Copy link
Collaborator

source-gitlab test report (commit ef9810aa28) - ❌

⏲️ Total pipeline duration: 12mn02s

Step Result
Build source-gitlab docker image for platform(s) linux/amd64
Unit tests
Acceptance tests
Check our base image is used
Code format checks
Validate metadata for source-gitlab
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-gitlab test

@airbyte-oss-build-runner
Copy link
Collaborator

source-gitlab test report (commit a95b4ceb32) - ❌

⏲️ Total pipeline duration: 06mn02s

Step Result
Build source-gitlab docker image for platform(s) linux/amd64
Unit tests
Acceptance tests
Check our base image is used
Code format checks
Validate metadata for source-gitlab
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-gitlab test

@airbyte-oss-build-runner
Copy link
Collaborator

source-gitlab test report (commit 24b9eb0ff6) - ✅

⏲️ Total pipeline duration: 05mn45s

Step Result
Build source-gitlab docker image for platform(s) linux/amd64
Unit tests
Acceptance tests
Check our base image is used
Code format checks
Validate metadata for source-gitlab
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-gitlab test

Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this point is cleared up, I'm good with the PR

docs/integrations/sources/gitlab.md Outdated Show resolved Hide resolved
@octavia-squidington-iv octavia-squidington-iv requested a review from a team October 23, 2023 17:54
@airbyte-oss-build-runner
Copy link
Collaborator

source-gitlab test report (commit 8eccb8de5b) - ✅

⏲️ Total pipeline duration: 12mn41s

Step Result
Build source-gitlab docker image for platform(s) linux/amd64
Unit tests
Acceptance tests
Check our base image is used
Code format checks
Validate metadata for source-gitlab
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-gitlab test

Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@darynaishchenko darynaishchenko added the breaking-change Don't merge me unless you are ready. label Oct 24, 2023
@darynaishchenko darynaishchenko changed the title 🐛 Source Gitlab: certification improvements: epics pk, date-time format, docs, allowed hosts 🚨 Source Gitlab: certification improvements: epics pk, date-time format, docs, allowed hosts Oct 24, 2023
docs/integrations/sources/gitlab-migrations.md Outdated Show resolved Hide resolved
docs/integrations/sources/gitlab.md Outdated Show resolved Hide resolved
docs/integrations/sources/gitlab.md Outdated Show resolved Hide resolved
@airbyte-oss-build-runner
Copy link
Collaborator

source-gitlab test report (commit 27d8798231) - ✅

⏲️ Total pipeline duration: 12mn27s

Step Result
Build source-gitlab docker image for platform(s) linux/amd64
Unit tests
Acceptance tests
Check our base image is used
Code format checks
Validate metadata for source-gitlab
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-gitlab test

@airbyte-oss-build-runner
Copy link
Collaborator

source-gitlab test report (commit 66791254de) - ✅

⏲️ Total pipeline duration: 08mn17s

Step Result
Build source-gitlab docker image for platform(s) linux/amd64
Unit tests
Acceptance tests
Check our base image is used
Code format checks
Validate metadata for source-gitlab
Connector version semver check
Connector version increment check
QA checks

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-gitlab test

@darynaishchenko darynaishchenko merged commit d7ba34d into master Oct 26, 2023
17 checks passed
@darynaishchenko darynaishchenko deleted the daryna/source-gitlab/epics-pk/date-time-format branch October 26, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation breaking-change Don't merge me unless you are ready. connectors/source/gitlab team/connectors-python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants