Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 Source Gitlab: certification improvements: epics pk, date-time format, docs, allowed hosts #31700

Merged
merged 11 commits into from
Oct 26, 2023
Merged

🚨 Source Gitlab: certification improvements: epics pk, date-time format, docs, allowed hosts #31700

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
44beb1a
changed epics PK from iid to id
darynaishchenko Oct 23, 2023
caae1d4
updated format for date-time fileds in deployments, group/projects me…
darynaishchenko Oct 23, 2023
a57e96c
updated docs and allowed hosts, encreased connector version
darynaishchenko Oct 23, 2023
0f3590f
updated changelog
darynaishchenko Oct 23, 2023
6a67e4f
revert pk changes, add pk definition for epic docs
darynaishchenko Oct 23, 2023
ef9810a
added breakingChanges to metadata
darynaishchenko Oct 23, 2023
a95b4ce
Automated Commit - Formatting Changes
darynaishchenko Oct 23, 2023
24b9eb0
added migration guide
darynaishchenko Oct 23, 2023
8eccb8d
expand epic pk descriprion
darynaishchenko Oct 24, 2023
27d8798
updated descriptions
darynaishchenko Oct 26, 2023
6679125
updated upgradeDeadline
darynaishchenko Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-gitlab/acceptance-test-config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ acceptance_tests:
tests:
- config_path: "secrets/config.json"
backward_compatibility_tests_config:
disable_for_version: 1.7.1
disable_for_version: 1.8.4
darynaishchenko marked this conversation as resolved.
Show resolved Hide resolved
basic_read:
tests:
- config_path: "secrets/config.json"
Expand Down
4 changes: 2 additions & 2 deletions airbyte-integrations/connectors/source-gitlab/integration_tests/configured_catalog.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,11 +250,11 @@
"name": "epics",
"json_schema": {},
"supported_sync_modes": ["full_refresh"],
"source_defined_primary_key": [["iid"]]
"source_defined_primary_key": [["id"]]
},
"sync_mode": "full_refresh",
"destination_sync_mode": "overwrite",
"primary_key": [["iid"]]
"primary_key": [["id"]]
},
{
"stream": {
Expand Down
4 changes: 2 additions & 2 deletions airbyte-integrations/connectors/source-gitlab/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@ data:
sl: 200
allowedHosts:
hosts:
- "*"
- ${api_url}
davydov-d marked this conversation as resolved.
Show resolved Hide resolved
connectorBuildOptions:
baseImage: docker.io/airbyte/python-connector-base:1.1.0@sha256:bd98f6505c6764b1b5f99d3aedc23dfc9e9af631a62533f60eb32b1d3dbab20c
connectorSubtype: api
connectorType: source
definitionId: 5e6175e5-68e1-4c17-bff9-56103bbb0d80
dockerImageTag: 1.8.4
dockerImageTag: 1.9.0
dockerRepository: airbyte/source-gitlab
documentationUrl: https://docs.airbyte.com/integrations/sources/gitlab
githubIssueLabel: source-gitlab
Expand Down
6 changes: 4 additions & 2 deletions airbyte-integrations/connectors/source-gitlab/source_gitlab/schemas/deployments.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,8 @@
"type": ["null", "object"],
"properties": {
"created_at": {
"type": ["null", "string"]
"type": ["null", "string"],
"format": "date-time"
},
"id": {
"type": ["null", "integer"]
Expand All @@ -195,7 +196,8 @@
"type": ["null", "string"]
},
"updated_at": {
"type": ["null", "string"]
"type": ["null", "string"],
"format": "date-time"
},
"web_url": {
"type": ["null", "string"]
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-gitlab/source_gitlab/schemas/group_members.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
},
"expires_at": {
"type": ["null", "string"],
"format": "date"
"format": "date-time"
},
"created_by": {
"avatar_url": {
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-gitlab/source_gitlab/schemas/project_members.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
},
"expires_at": {
"type": ["null", "string"],
"format": "date"
"format": "date-time"
},
"created_by": {
"avatar_url": {
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-gitlab/source_gitlab/streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ class Users(GitlabChildStream):


class Epics(GitlabChildStream):
primary_key = "iid"
darynaishchenko marked this conversation as resolved.
Show resolved Hide resolved
primary_key = "id"
darynaishchenko marked this conversation as resolved.
Show resolved Hide resolved
flatten_id_keys = ["author"]


Expand Down
84 changes: 41 additions & 43 deletions docs/integrations/sources/gitlab.md
View file
Open in desktop

Large diffs are not rendered by default.

Loading