✨ Source Bing Ads: add new stream AgeGenderAudienceReport #31712

artem1205 · 2023-10-23T15:40:56Z

What

Resolving #17380

How

remove old caching => use standard request_cache instead
add new reports: AgeGenderAudienceReport

🚨 User Impact 🚨

no breaking changes

Pre-merge Actions

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.

vercel · 2023-10-23T15:41:02Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
airbyte-docs	⬜️ Ignored (Inspect)	Visit Preview		Oct 24, 2023 3:01pm

github-actions · 2023-10-23T15:42:50Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

airbyte-oss-build-runner · 2023-10-24T09:50:29Z

source-bing-ads test report (commit `7d730d3ac4`) - ❌

⏲️ Total pipeline duration: 56.87s

Step	Result
Build source-bing-ads docker image for platform(s) linux/amd64	✅
Unit tests	❌
Code format checks	✅
Validate metadata for source-bing-ads	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-bing-ads test

airbyte-oss-build-runner · 2023-10-24T09:55:29Z

source-bing-ads test report (commit `a76f249368`) - ❌

⏲️ Total pipeline duration: 48.65s

Step	Result
Build source-bing-ads docker image for platform(s) linux/amd64	✅
Unit tests	❌
Code format checks	✅
Validate metadata for source-bing-ads	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-bing-ads test

airbyte-oss-build-runner · 2023-10-24T10:07:46Z

source-bing-ads test report (commit `0a61de1d46`) - ❌

⏲️ Total pipeline duration: 01mn11s

Step	Result
Build source-bing-ads docker image for platform(s) linux/amd64	✅
Unit tests	✅
Acceptance tests	❌
Check our base image is used	✅
Code format checks	✅
Validate metadata for source-bing-ads	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-bing-ads test

airbyte-oss-build-runner · 2023-10-24T10:30:00Z

source-bing-ads test report (commit `9ecbb29f49`) - ❌

⏲️ Total pipeline duration: 55.14s

Step	Result
Build source-bing-ads docker image for platform(s) linux/amd64	✅
Unit tests	✅
Acceptance tests	❌
Check our base image is used	✅
Code format checks	❌
Validate metadata for source-bing-ads	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-bing-ads test

airbyte-oss-build-runner · 2023-10-24T10:37:34Z

source-bing-ads test report (commit `b7c53f4ab6`) - ❌

⏲️ Total pipeline duration: 48.02s

Step	Result
Build source-bing-ads docker image for platform(s) linux/amd64	✅
Unit tests	✅
Acceptance tests	❌
Check our base image is used	✅
Code format checks	✅
Validate metadata for source-bing-ads	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-bing-ads test

airbyte-oss-build-runner · 2023-10-24T11:32:04Z

source-bing-ads test report (commit `b8e5c36c79`) - ❌

⏲️ Total pipeline duration: 27mn22s

Step	Result
Build source-bing-ads docker image for platform(s) linux/amd64	✅
Unit tests	✅
Acceptance tests	❌
Check our base image is used	✅
Code format checks	✅
Validate metadata for source-bing-ads	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-bing-ads test

bazarnov · 2023-10-24T12:39:54Z

Creds issues, while CAT run, expired token.

alafanechere

Approving the bypass reason addition.
Please make sure to merge only when you have 🟢 tests.

alafanechere · 2023-10-24T13:04:44Z

airbyte-integrations/connectors/source-bing-ads/acceptance-test-config.yml

+          - name: age_gender_audience_report_hourly
+            bypass_reason: "Hourly reports are disabled, because sync is too long"


Can you mention how long is it? We can tweak the timeout_seconds value.

description updated; hourly data fetched is limited to 180 days (or even maybe 14 days: found different numbers on 3rd-party sites)

airbyte-oss-build-runner · 2023-10-24T13:20:25Z

source-bing-ads test report (commit `7682351f7b`) - ❌

⏲️ Total pipeline duration: 42.60s

Step	Result
Build source-bing-ads docker image for platform(s) linux/amd64	✅
Unit tests	❌
Code format checks	✅
Validate metadata for source-bing-ads	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-bing-ads test

airbyte-oss-build-runner · 2023-10-24T14:07:49Z

source-bing-ads test report (commit `7edf7d28a3`) - ❌

⏲️ Total pipeline duration: 27mn15s

Step	Result
Build source-bing-ads docker image for platform(s) linux/amd64	✅
Unit tests	✅
Acceptance tests	✅
Check our base image is used	✅
Code format checks	❌
Validate metadata for source-bing-ads	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-bing-ads test

airbyte-oss-build-runner · 2023-10-24T15:19:08Z

source-bing-ads test report (commit `b2c833bf39`) - ✅

⏲️ Total pipeline duration: 15mn26s

Step	Result
Build source-bing-ads docker image for platform(s) linux/amd64	✅
Unit tests	✅
Acceptance tests	✅
Check our base image is used	✅
Code format checks	✅
Validate metadata for source-bing-ads	✅
Connector version semver check	✅
Connector version increment check	✅
QA checks	✅

🔗 View the logs here

☁️ View runs for commit in Dagger Cloud

Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command

airbyte-ci connectors --name=source-bing-ads test

Source Bing Ads: remove vcrpy caching

1d9b011

artem1205 self-assigned this Oct 23, 2023

octavia-squidington-iii added area/connectors Connector related issues connectors/source/bing-ads labels Oct 23, 2023

Source Bing Ads: refactor

70e9c35

artem1205 changed the title ~~Source Bing Ads: remove vcrpy caching~~ Source Bing Ads: add new reports Oct 23, 2023

Source Bing Ads: add new stream AgeGenderAudienceReport

c08a679

octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Oct 24, 2023

Source Bing Ads: flake ignore

7d730d3

artem1205 changed the title ~~Source Bing Ads: add new reports~~ ✨ Source Bing Ads: add new stream AgeGenderAudienceReport Oct 24, 2023

artem1205 marked this pull request as ready for review October 24, 2023 09:48

octavia-squidington-iv requested a review from a team October 24, 2023 09:49

artem1205 added 2 commits October 24, 2023 11:52

Source Bing Ads: update unit tests

d8e17ed

Source Bing Ads: update unit tests

a76f249

Source Bing Ads: update unit tests

0a61de1

Source Bing Ads: fix primary keys; update schema

9ecbb29

Source Bing Ads: format file

b7c53f4

Source Bing Ads: update CAT tests

b8e5c36

octavia-squidington-iv requested a review from a team October 24, 2023 11:04

Source Bing Ads: update CAT tests + use typetransformer

1ea45e4

alafanechere approved these changes Oct 24, 2023

View reviewed changes

alafanechere reviewed Oct 24, 2023

View reviewed changes

Source Bing Ads: update schema + expected records

7682351

Source Bing Ads: update unit test + CAT description

7edf7d2

artem1205 requested review from davydov-d and tolik0 October 24, 2023 14:05

Source Bing Ads: update unit test

b2c833b

artem1205 merged commit 718221f into master Oct 24, 2023
17 checks passed

artem1205 deleted the artem1205/source-bing-ads-new-reports branch October 24, 2023 15:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Source Bing Ads: add new stream AgeGenderAudienceReport #31712

✨ Source Bing Ads: add new stream AgeGenderAudienceReport #31712

artem1205 commented Oct 23, 2023 •

edited

Loading

vercel bot commented Oct 23, 2023 •

edited

Loading

github-actions bot commented Oct 23, 2023 •

edited by artem1205

Loading

airbyte-oss-build-runner commented Oct 24, 2023

airbyte-oss-build-runner commented Oct 24, 2023

airbyte-oss-build-runner commented Oct 24, 2023

airbyte-oss-build-runner commented Oct 24, 2023

airbyte-oss-build-runner commented Oct 24, 2023

airbyte-oss-build-runner commented Oct 24, 2023

bazarnov commented Oct 24, 2023

alafanechere left a comment

alafanechere Oct 24, 2023

artem1205 Oct 24, 2023

airbyte-oss-build-runner commented Oct 24, 2023

airbyte-oss-build-runner commented Oct 24, 2023

airbyte-oss-build-runner commented Oct 24, 2023

		- name: age_gender_audience_report_hourly
		bypass_reason: "Hourly reports are disabled, because sync is too long"

✨ Source Bing Ads: add new stream AgeGenderAudienceReport #31712

✨ Source Bing Ads: add new stream AgeGenderAudienceReport #31712

Conversation

artem1205 commented Oct 23, 2023 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Actions

Community member or Airbyter

Airbyter

vercel bot commented Oct 23, 2023 • edited Loading

github-actions bot commented Oct 23, 2023 • edited by artem1205 Loading

Before Merging a Connector Pull Request

airbyte-oss-build-runner commented Oct 24, 2023

source-bing-ads test report (commit 7d730d3ac4) - ❌

airbyte-oss-build-runner commented Oct 24, 2023

source-bing-ads test report (commit a76f249368) - ❌

airbyte-oss-build-runner commented Oct 24, 2023

source-bing-ads test report (commit 0a61de1d46) - ❌

airbyte-oss-build-runner commented Oct 24, 2023

source-bing-ads test report (commit 9ecbb29f49) - ❌

airbyte-oss-build-runner commented Oct 24, 2023

source-bing-ads test report (commit b7c53f4ab6) - ❌

airbyte-oss-build-runner commented Oct 24, 2023

source-bing-ads test report (commit b8e5c36c79) - ❌

bazarnov commented Oct 24, 2023

alafanechere left a comment

Choose a reason for hiding this comment

alafanechere Oct 24, 2023

Choose a reason for hiding this comment

artem1205 Oct 24, 2023

Choose a reason for hiding this comment

airbyte-oss-build-runner commented Oct 24, 2023

source-bing-ads test report (commit 7682351f7b) - ❌

airbyte-oss-build-runner commented Oct 24, 2023

source-bing-ads test report (commit 7edf7d28a3) - ❌

airbyte-oss-build-runner commented Oct 24, 2023

source-bing-ads test report (commit b2c833bf39) - ✅

artem1205 commented Oct 23, 2023 •

edited

Loading

vercel bot commented Oct 23, 2023 •

edited

Loading

github-actions bot commented Oct 23, 2023 •

edited by artem1205

Loading

source-bing-ads test report (commit `7d730d3ac4`) - ❌

source-bing-ads test report (commit `a76f249368`) - ❌

source-bing-ads test report (commit `0a61de1d46`) - ❌

source-bing-ads test report (commit `9ecbb29f49`) - ❌

source-bing-ads test report (commit `b7c53f4ab6`) - ❌

source-bing-ads test report (commit `b8e5c36c79`) - ❌

source-bing-ads test report (commit `7682351f7b`) - ❌

source-bing-ads test report (commit `7edf7d28a3`) - ❌

source-bing-ads test report (commit `b2c833bf39`) - ✅