-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Source Bing Ads: add new stream AgeGenderAudienceReport #31712
Merged
Merged
Changes from 10 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
1d9b011
Source Bing Ads: remove vcrpy caching
artem1205 70e9c35
Source Bing Ads: refactor
artem1205 c08a679
Source Bing Ads: add new stream AgeGenderAudienceReport
artem1205 7d730d3
Source Bing Ads: flake ignore
artem1205 d8e17ed
Source Bing Ads: update unit tests
artem1205 a76f249
Source Bing Ads: update unit tests
artem1205 0a61de1
Source Bing Ads: update unit tests
artem1205 9ecbb29
Source Bing Ads: fix primary keys; update schema
artem1205 b7c53f4
Source Bing Ads: format file
artem1205 b8e5c36
Source Bing Ads: update CAT tests
artem1205 1ea45e4
Source Bing Ads: update CAT tests + use typetransformer
artem1205 7682351
Source Bing Ads: update schema + expected records
artem1205 7edf7d2
Source Bing Ads: update unit test + CAT description
artem1205 b2c833b
Source Bing Ads: update unit test
artem1205 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
...ds/integration_tests/expected_records.txt → .../integration_tests/expected_records.jsonl
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 changes: 0 additions & 42 deletions
42
airbyte-integrations/connectors/source-bing-ads/source_bing_ads/cache.py
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
108 changes: 108 additions & 0 deletions
108
...ations/connectors/source-bing-ads/source_bing_ads/schemas/age_gender_audience_report.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,108 @@ | ||
{ | ||
"$schema": "https://json-schema.org/draft-07/schema#", | ||
"type": "object", | ||
"properties": { | ||
"AccountId": { | ||
"type": ["null", "integer"] | ||
}, | ||
"AgeGroup": { | ||
"type": ["null", "string"] | ||
}, | ||
"Gender": { | ||
"type": ["null", "string"] | ||
}, | ||
"TimePeriod": { | ||
"type": ["null", "string"] | ||
}, | ||
"AllConversions": { | ||
"type": ["null", "integer"] | ||
}, | ||
"AccountName": { | ||
"type": ["null", "string"] | ||
}, | ||
"AccountNumber": { | ||
"type": ["null", "string"] | ||
}, | ||
"CampaignName": { | ||
"type": ["null", "string"] | ||
}, | ||
"CampaignId": { | ||
"type": ["null", "integer"] | ||
}, | ||
"AdGroupName": { | ||
"type": ["null", "string"] | ||
}, | ||
"AdGroupId": { | ||
"type": ["null", "integer"] | ||
}, | ||
"AdDistribution": { | ||
"type": ["null", "string"] | ||
}, | ||
"Impressions": { | ||
"type": ["null", "integer"] | ||
}, | ||
"Clicks": { | ||
"type": ["null", "integer"] | ||
}, | ||
"Conversions": { | ||
"type": ["null", "number"] | ||
}, | ||
"Spend": { | ||
"type": ["null", "number"] | ||
}, | ||
"Revenue": { | ||
"type": ["null", "number"] | ||
}, | ||
"ExtendedCost": { | ||
"type": ["null", "number"] | ||
}, | ||
"Assists": { | ||
"type": ["null", "integer"] | ||
}, | ||
"Language": { | ||
"type": ["null", "string"] | ||
}, | ||
"AccountStatus": { | ||
"type": ["null", "string"] | ||
}, | ||
"CampaignStatus": { | ||
"type": ["null", "string"] | ||
}, | ||
"AdGroupStatus": { | ||
"type": ["null", "string"] | ||
}, | ||
"BaseCampaignId": { | ||
"type": ["null", "string"] | ||
}, | ||
"AllRevenue": { | ||
"type": ["null", "number"] | ||
}, | ||
"ViewThroughConversions": { | ||
"type": ["null", "integer"] | ||
}, | ||
"Goal": { | ||
"type": ["null", "string"] | ||
}, | ||
"GoalType": { | ||
"type": ["null", "string"] | ||
}, | ||
"AbsoluteTopImpressionRatePercent": { | ||
"type": ["null", "string"] | ||
}, | ||
"TopImpressionRatePercent": { | ||
"type": ["null", "string"] | ||
}, | ||
"ConversionsQualified": { | ||
"type": ["null", "number"] | ||
}, | ||
"AllConversionsQualified": { | ||
"type": ["null", "number"] | ||
}, | ||
"ViewThroughConversionsQualified": { | ||
"type": ["null", "number"] | ||
}, | ||
"ViewThroughRevenue": { | ||
"type": ["null", "number"] | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you mention how long is it? We can tweak the
timeout_seconds
value.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description updated; hourly data fetched is limited to 180 days (or even maybe 14 days: found different numbers on 3rd-party sites)