-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨URL encode username and password fields #32028
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
That's odd, I did validate those changes against that connector. Evidently not well enough. I'll look into it. |
I ran the test you mentioned on master and it works for me. |
Hi, I saw the URI encoding for the MongoDB connector was removed. I’m not sure if things have changed since the original issue was created but the lack of encoding for passwords was what caused the issue to be made. |
Yup, that's what I realized now by testing. |
/approve-and-merge reason="Tests for mongodb-v2 are passing. for some reason it is testing other connectors that are not part of the update" |
What
Adopting code change from #31371.
Fixes #10569
This code change also integrates with the latest CDK, adding debezium 2.4 and fixes https://github.com/airbytehq/oncall/issues/3203
How
URL encode the user and password fields as described in mongodb documentation
h/t to @aglucky for the original change