Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨URL encode username and password fields #32028

Merged
merged 12 commits into from
Nov 1, 2023

Conversation

rodireich
Copy link
Contributor

@rodireich rodireich commented Oct 31, 2023

What

Adopting code change from #31371.
Fixes #10569

This code change also integrates with the latest CDK, adding debezium 2.4 and fixes https://github.com/airbytehq/oncall/issues/3203

How

URL encode the user and password fields as described in mongodb documentation
h/t to @aglucky for the original change

Copy link

vercel bot commented Oct 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2023 7:10pm

Copy link
Contributor

github-actions bot commented Oct 31, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@rodireich rodireich changed the title bump version URL encode username and password fields Oct 31, 2023
@rodireich rodireich requested a review from a team October 31, 2023 22:46
@rodireich rodireich changed the title URL encode username and password fields ✨URL encode username and password fields Oct 31, 2023
@rodireich rodireich marked this pull request as ready for review October 31, 2023 22:49
@rodireich
Copy link
Contributor Author

@postamar It looks like the change in #31960 broke source-mongodb-v2.
Running the following for example on master is failing as well:

./gradlew :airbyte-integrations:connectors:source-mongodb-v2:integrationTestJava --tests "io.airbyte.integrations.source.mongodb.MongoDbSourceAcceptanceTest"

@postamar
Copy link
Contributor

postamar commented Nov 1, 2023

That's odd, I did validate those changes against that connector. Evidently not well enough. I'll look into it.

@postamar
Copy link
Contributor

postamar commented Nov 1, 2023

I ran the test you mentioned on master and it works for me.

@aglucky
Copy link

aglucky commented Nov 1, 2023

Hi, I saw the URI encoding for the MongoDB connector was removed. I’m not sure if things have changed since the original issue was created but the lack of encoding for passwords was what caused the issue to be made.

@rodireich
Copy link
Contributor Author

Yup, that's what I realized now by testing.
Docs are not clear about it. But I think It's the right combination the way it is now.
Hopefully tests should pass now.

@rodireich rodireich enabled auto-merge (squash) November 1, 2023 19:06
@rodireich
Copy link
Contributor Author

/approve-and-merge reason="Tests for mongodb-v2 are passing. for some reason it is testing other connectors that are not part of the update"

@octavia-approvington
Copy link
Contributor

Lets merge it
sheep thumbs up

@octavia-approvington octavia-approvington merged commit f5c8796 into master Nov 1, 2023
27 checks passed
@octavia-approvington octavia-approvington deleted the 3203-source-mongodb-connector branch November 1, 2023 20:22
@rodireich rodireich restored the 3203-source-mongodb-connector branch November 1, 2023 20:34
@rodireich rodireich deleted the 3203-source-mongodb-connector branch November 1, 2023 20:40
@rodireich rodireich restored the 3203-source-mongodb-connector branch November 1, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source MongoDB: connector fail with password which contains special character
6 participants