Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨URL encode username and password fields #32028

Merged
merged 12 commits into from
Nov 1, 2023
Merged

✨URL encode username and password fields #32028

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2a5c9db
bump version
rodireich Oct 31, 2023
8976fa5
changelog
rodireich Oct 31, 2023
d0724ce
url encode username and password
rodireich Oct 31, 2023
812e121
bump version
rodireich Oct 31, 2023
26e2e6a
Update build.gradle
rodireich Nov 1, 2023
6fcb106
Merge branch 'master' into 3203-source-mongodb-connector
rodireich Nov 1, 2023
b310778
test
rodireich Nov 1, 2023
03cd17f
Update build.gradle
rodireich Nov 1, 2023
32addc1
Merge branch 'master' into 3203-source-mongodb-connector
rodireich Nov 1, 2023
efa1458
No need to encode the password
rodireich Nov 1, 2023
69c3030
Merge branch 'master' into 3203-source-mongodb-connector
rodireich Nov 1, 2023
ee50e53
Automated Commit - Formatting Changes
rodireich Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-mongodb-v2/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ plugins {
}

airbyteJavaConnector {
cdkVersionRequired = '0.2.0'
cdkVersionRequired = '0.2.4'
features = ['db-sources']
useLocalCdk = false
}
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-mongodb-v2/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ data:
connectorSubtype: database
connectorType: source
definitionId: b2e713cd-cc36-4c0a-b5bd-b47cb8a0561e
dockerImageTag: 1.0.4
dockerImageTag: 1.0.5
dockerRepository: airbyte/source-mongodb-v2
documentationUrl: https://docs.airbyte.com/integrations/sources/mongodb-v2
githubIssueLabel: source-mongodb-v2
Expand Down
6 changes: 4 additions & 2 deletions ...mongodb-v2/src/main/java/io/airbyte/integrations/source/mongodb/MongoConnectionUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
import com.mongodb.client.MongoClient;
import com.mongodb.client.MongoClients;
import io.airbyte.cdk.integrations.debezium.internals.mongodb.MongoDbDebeziumPropertiesManager;
import java.net.URLEncoder;
import java.nio.charset.StandardCharsets;

/**
* Helper utility for building a {@link MongoClient}.
Expand All @@ -39,8 +41,8 @@ public static MongoClient createMongoClient(final MongoDbSourceConfig config) {

if (config.hasAuthCredentials()) {
final String authSource = config.getAuthSource();
final String user = config.getUsername();
final String password = config.getPassword();
final String user = URLEncoder.encode(config.getUsername(), StandardCharsets.UTF_8);
final String password = URLEncoder.encode(config.getPassword(), StandardCharsets.UTF_8);
mongoClientSettingsBuilder.credential(MongoCredential.createCredential(user, authSource, password.toCharArray()));
}

Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/mongodb-v2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,7 @@ For more information regarding configuration parameters, please see [MongoDb Doc

| Version | Date | Pull Request | Subject |
|:--------|:-----------|:---------------------------------------------------------|:----------------------------------------------------------------------------------------------------------|
| 1.0.5 | 2023-10-31 | [32028](https://github.com/airbytehq/airbyte/pull/32028) | url encode username and password.<br/>Handle a case of document update and delete in a single sync. |
| 1.0.3 | 2023-10-19 | [31629](https://github.com/airbytehq/airbyte/pull/31629) | Allow discover operation use of disk file when an operation goes over max allowed mem |
| 1.0.2 | 2023-10-19 | [31596](https://github.com/airbytehq/airbyte/pull/31596) | Allow use of temp disk file when an operation goes over max allowed mem |
| 1.0.1 | 2023-10-03 | [31034](https://github.com/airbytehq/airbyte/pull/31034) | Fix field filtering logic related to nested documents |
Expand Down
Loading