-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CDK: Fix class SessionTokenAuthenticator for CLASS_TYPES_REGISTRY mapper #32040
CDK: Fix class SessionTokenAuthenticator for CLASS_TYPES_REGISTRY mapper #32040
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -56,7 +56,7 @@ | |||
""" | |||
CLASS_TYPES_REGISTRY contains a mapping of developer-friendly string -> class to abstract the specific class referred to | |||
""" | |||
CLASS_TYPES_REGISTRY: Mapping[str, Type] = { | |||
CLASS_TYPES_REGISTRY: Mapping[str, type] = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've answered here: #31696 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for fixing!
…/cdk/fix-registry-for-session-token-authenticator
What
Describe what the change is solving
It helps to add screenshots if it affects the frontend.
How
Change
SessionTokenAuthenticator
toLegacySessionTokenAuthenticator
Recommended reading order
airbyte-cdk/python/airbyte_cdk/sources/declarative/parsers/class_types_registry.py
Pre-merge Actions
Airbyter
Before merging:
--use-local-cdk --name=source-<connector>
as optionsairbyte-ci connectors --use-local-cdk --name=source-<connector> test
After merging: