Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDK: Fix class SessionTokenAuthenticator for CLASS_TYPES_REGISTRY mapper #32040

Conversation

yevhenii-ldv
Copy link
Contributor

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Change SessionTokenAuthenticator to LegacySessionTokenAuthenticator

Recommended reading order

  1. airbyte-cdk/python/airbyte_cdk/sources/declarative/parsers/class_types_registry.py

Pre-merge Actions

Airbyter

Before merging:

  • Pull Request description explains what problem it is solving
  • Code change is unit tested
  • Build and my-py check pass
  • Smoke test the change on at least one affected connector
    • On Github: Run this workflow, passing --use-local-cdk --name=source-<connector> as options
    • Locally: airbyte-ci connectors --use-local-cdk --name=source-<connector> test
  • PR is reviewed and approved

After merging:

  • Publish the CDK
    • The CDK does not follow proper semantic versioning. Choose minor if this the change has significant user impact or is a breaking change. Choose patch otherwise.
    • Write a thoughtful changelog message so we know what was updated.
  • Merge the platform PR that was auto-created for updating the Connector Builder's CDK version
    • This step is optional if the change does not affect the connector builder or declarative connectors.

@yevhenii-ldv yevhenii-ldv requested a review from a team as a code owner November 1, 2023 12:26
Copy link

vercel bot commented Nov 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 2, 2023 3:39pm

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Nov 1, 2023
@yevhenii-ldv yevhenii-ldv changed the title CDK: Fix class for SessionTokenAuthenticator for CLASS_TYPES_REGISTRY mapper CDK: Fix class SessionTokenAuthenticator for CLASS_TYPES_REGISTRY mapper Nov 1, 2023
@yevhenii-ldv yevhenii-ldv requested review from girarda and keu November 1, 2023 12:46
@@ -56,7 +56,7 @@
"""
CLASS_TYPES_REGISTRY contains a mapping of developer-friendly string -> class to abstract the specific class referred to
"""
CLASS_TYPES_REGISTRY: Mapping[str, Type] = {
CLASS_TYPES_REGISTRY: Mapping[str, type] = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change?

Copy link
Contributor Author

@yevhenii-ldv yevhenii-ldv Nov 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've answered here: #31696 (comment)

Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: thanks for fixing!

…/cdk/fix-registry-for-session-token-authenticator
@yevhenii-ldv yevhenii-ldv merged commit ace4353 into master Nov 2, 2023
15 checks passed
@yevhenii-ldv yevhenii-ldv deleted the ykurochkin/cdk/fix-registry-for-session-token-authenticator branch November 2, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants