Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDK: Fix class SessionTokenAuthenticator for CLASS_TYPES_REGISTRY mapper #32040

Merged
merged 3 commits into from
Nov 2, 2023
Merged

CDK: Fix class SessionTokenAuthenticator for CLASS_TYPES_REGISTRY mapper #32040

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a168350
CDK: Fix class for SessionTokenAuthenticator for CLASS_TYPES_REGISTRY…
yevhenii-ldv Nov 1, 2023
75dead3
Fix mypy
yevhenii-ldv Nov 1, 2023
b3998fb
Merge branch 'master' of github.com:airbytehq/airbyte into ykurochkin…
yevhenii-ldv Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions airbyte-cdk/python/airbyte_cdk/sources/declarative/parsers/class_types_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@
# Copyright (c) 2023 Airbyte, Inc., all rights reserved.
#

from typing import Mapping, Type
from typing import Mapping

from airbyte_cdk.sources.declarative.auth.declarative_authenticator import NoAuth
from airbyte_cdk.sources.declarative.auth.oauth import DeclarativeOauth2Authenticator
from airbyte_cdk.sources.declarative.auth.token import (
ApiKeyAuthenticator,
BasicHttpAuthenticator,
BearerAuthenticator,
SessionTokenAuthenticator,
LegacySessionTokenAuthenticator,
)
from airbyte_cdk.sources.declarative.checks import CheckStream
from airbyte_cdk.sources.declarative.datetime.min_max_datetime import MinMaxDatetime
Expand Down Expand Up @@ -56,7 +56,7 @@
"""
CLASS_TYPES_REGISTRY contains a mapping of developer-friendly string -> class to abstract the specific class referred to
"""
CLASS_TYPES_REGISTRY: Mapping[str, Type] = {
CLASS_TYPES_REGISTRY: Mapping[str, type] = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change?

Copy link
Contributor Author

@yevhenii-ldv yevhenii-ldv Nov 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've answered here: #31696 (comment)

"AddedFieldDefinition": AddedFieldDefinition,
"AddFields": AddFields,
"ApiKeyAuthenticator": ApiKeyAuthenticator,
Expand Down Expand Up @@ -96,7 +96,7 @@
"SimpleRetriever": SimpleRetriever,
"Spec": Spec,
"SubstreamPartitionRouter": SubstreamPartitionRouter,
"SessionTokenAuthenticator": SessionTokenAuthenticator,
"SessionTokenAuthenticator": LegacySessionTokenAuthenticator,
"WaitUntilTimeFromHeader": WaitUntilTimeFromHeaderBackoffStrategy,
"WaitTimeFromHeader": WaitTimeFromHeaderBackoffStrategy,
}
Loading