bubble up debezium config error messages as exceptions #33658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
In this stack: This stack of pull requests is managed by Graphite. Learn more about stacking. Join @stephane-airbyte and the rest of your teammates on |
akashkulk
approved these changes
Dec 19, 2023
stephane-airbyte
force-pushed
the
stephane/12-19-bubble_up_debezium_config_error_messages_as_exceptions
branch
from
3d9910c to
86a9add
Compare
…rror_messages_as_exceptions
|
/publish-java-cdk
|
stephane-airbyte
deleted the
stephane/12-19-bubble_up_debezium_config_error_messages_as_exceptions
branch
Merge activity
|
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
Looks like the logic of handling the result of the debezium engine was slightly wrong. Wee were assining the local `error` field, and then checking itf it was not null, and overriding it in that case. The truth is that the engine can fail without filling in the `error` field, but still fill in the `message` field. So the new logic uses the `message` field if `error` is null fixes airbytehq#31579
jatinyadav-cc
pushed a commit
to ollionorg/datapipes-airbyte
that referenced
this pull request
Feb 26, 2024
Looks like the logic of handling the result of the debezium engine was slightly wrong. Wee were assining the local `error` field, and then checking itf it was not null, and overriding it in that case. The truth is that the engine can fail without filling in the `error` field, but still fill in the `message` field. So the new logic uses the `message` field if `error` is null fixes airbytehq#31579
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the logic of handling the result of the debezium engine was slightly wrong. Wee were assining the local
errorfield, and then checking itf it was not null, and overriding it in that case. The truth is that the engine can fail without filling in theerrorfield, but still fill in themessagefield. So the new logic uses themessagefield iferroris nullfixes #31579