Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bubble up debezium config error messages as exceptions #33658

Merged
merged 2 commits into from
Jan 9, 2024
Merged

bubble up debezium config error messages as exceptions #33658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86a9add
bubble up debezium config error messages as exceptions
stephane-airbyte Dec 19, 2023
9b3052c
Merge branch 'master' into stephane/12-19-bubble_up_debezium_config_e…
stephane-airbyte Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions airbyte-cdk/java/airbyte-cdk/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ MavenLocal debugging steps:

| Version | Date | Pull Request | Subject |
|:--------|:-----------|:-----------------------------------------------------------|:---------------------------------------------------------------------------------------------------------------------------------------------------------------|
| 0.11.3 | 2023-01-09 | [\#33658](https://github.com/airbytehq/airbyte/pull/33658) | Always fail when debezium fails, even if it happened during the setup phase. |
| 0.11.2 | 2024-01-09 | [\#33969](https://github.com/airbytehq/airbyte/pull/33969) | Destination state stats implementation |
| 0.11.1 | 2024-01-04 | [\#33727](https://github.com/airbytehq/airbyte/pull/33727) | SSH bastion heartbeats for Destinations |
| 0.11.0 | 2024-01-04 | [\#33730](https://github.com/airbytehq/airbyte/pull/33730) | DV2 T+D uses Sql struct to represent transactions; other T+D-related changes |
Expand Down
2 changes: 1 addition & 1 deletion airbyte-cdk/java/airbyte-cdk/core/src/main/resources/version.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
version=0.11.2
version=0.11.3
14 changes: 8 additions & 6 deletions ...src/main/java/io/airbyte/cdk/integrations/debezium/internals/DebeziumRecordPublisher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,12 +86,14 @@ public void start(final BlockingQueue<ChangeEvent<String, String>> queue) {
.using((success, message, error) -> {
LOGGER.info("Debezium engine shutdown. Engine terminated successfully : {}", success);
LOGGER.info(message);
thrownError.set(error);
// If debezium has not shutdown correctly, it can indicate an error with the connector configuration
// or a partial sync success.
// In situations like these, the preference is to fail loud and clear.
if (thrownError.get() != null && !success) {
thrownError.set(new RuntimeException(message));
if (!success) {
if (error != null) {
thrownError.set(error);
} else {
// There are cases where Debezium doesn't succeed but only fills the message field.
// In that case, we still want to fail loud and clear
thrownError.set(new RuntimeException(message));
}
}
engineLatch.countDown();
})
Expand Down
Loading