Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Chargebee: Adds fields, Adds streams, removes bypass for streams, adds expected records #33696

Merged
merged 24 commits into from
Jan 3, 2024

Conversation

pnilan
Copy link
Contributor

@pnilan pnilan commented Dec 20, 2023

What

Copy link

vercel bot commented Dec 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2024 4:24pm

Copy link
Contributor

github-actions bot commented Dec 20, 2023

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@pnilan pnilan marked this pull request as ready for review December 20, 2023 22:38
@octavia-squidington-iv octavia-squidington-iv requested review from a team December 20, 2023 22:39
@pnilan pnilan changed the base branch from master to codefreeze-23-12/source-chargebee/0.2.6 December 21, 2023 17:18
Copy link
Contributor

github-actions bot commented Dec 21, 2023

Warning

🚨 Connector code freeze is in effect until 2024-01-02. This PR is changing connector code. Please contact the current OC engineers if you want to merge this change to master.

@pnilan pnilan changed the title Source Chargebee: Removes test bypass for streams Source Chargebee: Adds fields, Adds streams, removes bypass for streams, adds expected records Dec 28, 2023
Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@octavia-squidington-iv octavia-squidington-iv requested a review from a team January 3, 2024 16:13
@pnilan pnilan changed the base branch from codefreeze-23-12/source-chargebee/0.2.6 to master January 3, 2024 20:19
@pnilan pnilan merged commit 69da92e into master Jan 3, 2024
27 of 28 checks passed
@pnilan pnilan deleted the pnilan/source-chargebee-CAT-fix branch January 3, 2024 20:21
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
jatinyadav-cc pushed a commit to ollionorg/datapipes-airbyte that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/chargebee
Projects
None yet
3 participants