Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Source Bing Ads: Stream budget and product dimension performance report #35201

Merged
merged 38 commits into from
Mar 1, 2024
Merged

✨ Source Bing Ads: Stream budget and product dimension performance report #35201

merged 38 commits into from
Mar 1, 2024

Conversation

darynaishchenko
Copy link
Collaborator

[Note for reviewers] cat will be fixed as part of connector health

What

Resolved; https://github.com/airbytehq/airbyte-internal-issues/issues/976 https://github.com/airbytehq/airbyte-internal-issues/issues/1785

How

Added new streams Budget and Product Dimension Performance Report Hourly/Daily/Weekly/Monthly

Recommended reading order

  1. airbyte-integrations/connectors/source-bing-ads/source_bing_ads
  2. airbyte-integrations/connectors/source-bing-ads/unit_tests/integrations/
  3. other files

🚨 User Impact 🚨

Not a breaking change.

@darynaishchenko darynaishchenko self-assigned this Feb 13, 2024
@vercel Vercel
Copy link

vercel bot commented Feb 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2024 9:28am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Feb 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 13, 2024 •
edited by darynaishchenko
Loading

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan.
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • You've updated the connector's metadata.yaml file any other relevant changes, including a breakingChanges entry for major version bumps. See metadata.yaml docs
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • Migration guide updated in docs/integrations/<source or destination>/<name>-migrations.md with an entry for the new version, if the version is a breaking change. See migration guide example
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@octavia-squidington-iv octavia-squidington-iv requested review from a team February 13, 2024 11:31
askarpets
askarpets suggested changes Feb 14, 2024
View reviewed changes
airbyte-integrations/connectors/source-bing-ads/unit_tests/integrations/catalog_builder.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-bing-ads/unit_tests/integrations/client_builder.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-bing-ads/unit_tests/integrations/client_builder.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-bing-ads/unit_tests/integrations/client_builder.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-bing-ads/unit_tests/integrations/client_builder.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-bing-ads/unit_tests/integrations/test_budget_stream.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-bing-ads/unit_tests/integrations/test_budget_stream.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-bing-ads/unit_tests/integrations/test_bulk_stream.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-bing-ads/unit_tests/integrations/test_bulk_stream.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-bing-ads/unit_tests/integrations/test_report_stream.py Outdated Show resolved Hide resolved
askarpets
askarpets suggested changes Feb 20, 2024
View reviewed changes
airbyte-integrations/connectors/source-bing-ads/unit_tests/integrations/client_builder.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-bing-ads/unit_tests/integrations/config.py Outdated
"client_secret": self._client_secret,
"lookback_window": self._lookback_window,
}
if self._report_start_date:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but is it possible that the _report_start_date is not present in this config?

airbyte-integrations/connectors/source-bing-ads/unit_tests/integrations/test_bulk_stream.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-bing-ads/unit_tests/integrations/test_bulk_stream.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-bing-ads/unit_tests/integrations/test_bulk_stream.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-bing-ads/unit_tests/integrations/test_report_stream.py Outdated Show resolved Hide resolved
airbyte-integrations/connectors/source-bing-ads/unit_tests/integrations/test_report_stream.py Outdated Show resolved Hide resolved
maxi297
maxi297 reviewed Feb 26, 2024
View reviewed changes
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment but it looks good to me in terms of code + testing to me. I want to highlight that I have no domain knowledge on Bing Ads so if someone from API Sources could verify that, it would be great!

...nectors/source-bing-ads/unit_tests/integrations/test_product_dimension_performance_report.py Outdated Show resolved Hide resolved
@octavia-squidington-iv octavia-squidington-iv requested a review from a team February 26, 2024 21:32
maxi297
maxi297 approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@darynaishchenko darynaishchenko merged commit bcf32a2 into master Mar 1, 2024
28 of 29 checks passed
@darynaishchenko darynaishchenko deleted the daryna/source-bing-ads/stream-budget-and-product_dimension_performance_report branch March 1, 2024 10:34
xiaohansong pushed a commit that referenced this pull request Mar 7, 2024
@darynaishchenko @xiaohansong
✨ Source Bing Ads: Stream budget and product dimension performance re…
0e23ec2 
…port (#35201)
@darynaishchenko darynaishchenko mentioned this pull request Mar 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askarpets askarpets askarpets approved these changes

@maxi297 maxi297 maxi297 approved these changes

@artem1205 artem1205 Awaiting requested review from artem1205

Assignees

@darynaishchenko darynaishchenko

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/bing-ads
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@darynaishchenko @maxi297 @askarpets @octavia-squidington-iii