-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Source Bing Ads: Stream budget and product dimension performance report #35201
Merged
darynaishchenko
merged 38 commits into
master
from
daryna/source-bing-ads/stream-budget-and-product_dimension_performance_report
Mar 1, 2024
Merged
Changes from 33 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
b3ddb10
added stream budget
darynaishchenko a3b14d9
added stream product dimensaion
darynaishchenko 8c5d87a
updated streams
darynaishchenko 1ae6396
added integration tests for new streams
darynaishchenko d3a6232
added resourse data for tests
darynaishchenko cb66910
updated streams value in unit test
darynaishchenko ead65d6
updated cat config with new streams
darynaishchenko 3463422
updated docs and metadata
darynaishchenko 3cb5312
format fix
darynaishchenko 00a75a8
Merge branch 'master' into daryna/source-bing-ads/stream-budget-and-p…
darynaishchenko d73596e
updated changelog
darynaishchenko 95d8e24
fixed cat config
darynaishchenko 571146e
refactored code
darynaishchenko 121cdbf
added BaseTest, updated TestBulkStreams and TestreportStreams
darynaishchenko 897d2c3
updated client mock logic
darynaishchenko b07be18
fix hints
darynaishchenko 92bb09d
updated product_dimension_performance_report data
darynaishchenko 7b11e0f
updated TestSuiteReportStream with skipp for base test
darynaishchenko ba7c69d
remove redundant headers
darynaishchenko 5d2f8fd
format fix
darynaishchenko 4616384
updated state for streams
darynaishchenko ebd0921
deleted catalog builder
darynaishchenko c48aa81
updated BaseTest
darynaishchenko f4bae3b
updated response data
darynaishchenko a895fa4
updated TestBudgetStream
darynaishchenko e9346de
updated TestSuiteReportStream
darynaishchenko 3374d11
updated test_return_records_from_given_csv_file for Budget stream test
darynaishchenko a6d89c2
updated resource data
darynaishchenko 5380892
added unittest for ioe case
darynaishchenko b8e683f
updated integration tests with state validation in request
darynaishchenko ca13f4f
updated test dates for monthly report
darynaishchenko 7156617
Merge branch 'master' into daryna/source-bing-ads/stream-budget-and-p…
darynaishchenko f55b223
updated vesrion in pyproject.toml
darynaishchenko ec0a696
test stream budget: fix date for incremental sync
darynaishchenko 5a29581
budget and product: updated cat config
darynaishchenko aaad088
updated budget schema
darynaishchenko df4c4f8
Merge branch 'master' into daryna/source-bing-ads/stream-budget-and-p…
darynaishchenko 66a0cc5
Merge branch 'master' into daryna/source-bing-ads/stream-budget-and-p…
darynaishchenko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ requires = [ "poetry-core>=1.0.0",] | |
build-backend = "poetry.core.masonry.api" | ||
|
||
[tool.poetry] | ||
version = "2.1.4" | ||
version = "2.2.0" | ||
name = "source-bing-ads" | ||
description = "Source implementation for Bing Ads." | ||
authors = [ "Airbyte <[email protected]>",] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 39 additions & 0 deletions
39
airbyte-integrations/connectors/source-bing-ads/source_bing_ads/schemas/budget.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
{ | ||
"$schema": "https://json-schema.org/draft-07/schema#", | ||
"type": "object", | ||
"properties": { | ||
"Account Id": { | ||
"type": ["null", "integer"] | ||
}, | ||
"Type": { | ||
"type": ["null", "string"] | ||
}, | ||
"Status": { | ||
"type": ["null", "string"] | ||
}, | ||
"Id": { | ||
"type": ["null", "integer"] | ||
}, | ||
"Parent Id": { | ||
"type": ["null", "integer"] | ||
}, | ||
"Client Id": { | ||
"type": ["null", "integer"] | ||
}, | ||
"Modified Time": { | ||
"type": ["null", "string"] | ||
}, | ||
"Budget Id": { | ||
"type": ["null", "integer"] | ||
}, | ||
"Budget Name": { | ||
"type": ["null", "string"] | ||
}, | ||
"Budget": { | ||
"type": ["null", "string"] | ||
}, | ||
"Budget Type": { | ||
"type": ["null", "string"] | ||
} | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we document why it is empty? I personally prefer to test things in integration anyway but this is unusual given how we do things today
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will update cat config with this info