-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Destination Snowflake: Write extracted_at in UTC #35308
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Before Merging a Connector Pull RequestWow! What a great pull request you have here! 🎉 To merge this PR, ensure the following has been done/considered for each connector added or updated:
If the checklist is complete, but the CI check is failing,
|
62a8eb4
to
a05927a
Compare
350f326
to
9b0bca9
Compare
a05927a
to
47d114e
Compare
346f804
to
cc4cd5f
Compare
3829bea
to
bbe9cde
Compare
801bc47
to
cffd162
Compare
bbe9cde
to
9f7d650
Compare
cffd162
to
391988a
Compare
9f7d650
to
863ef4a
Compare
Signed-off-by: Gireesh Sreepathi <[email protected]>
Signed-off-by: Gireesh Sreepathi <[email protected]>
Signed-off-by: Gireesh Sreepathi <[email protected]>
d5c2bce
to
61b2d99
Compare
Signed-off-by: Gireesh Sreepathi <[email protected]> Co-authored-by: Gireesh Sreepathi <[email protected]>
Hopefully most changes are reasonably self-explanatory, but a few callouts:
destination-snowflake:3.5.11
, i.e. a version that still wrote extracted_at in the user local timezone instead of UTC. I added someltz_*_expectedrecords_*.jsonl
files to verify that that sync behaved as expected - not strictly necessary, but it's nice to have a baseline assertion that the known-bad sync behaved in the way that we expect.-08:00
toZ
.We are not migrating existing timestamps in raw tables or final tables, instead we are relying on timestamp arithmetic to always force normalize it to UTC as below. Also as part of this PR, we are removing the optimization to use
_airbyte_extracted_at > [a very old value]
because of using the following conversion, that query became slow.