Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination Snowflake: Write extracted_at in UTC #35308

Merged
merged 33 commits into from
Mar 6, 2024
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
2aa4aa5
snowflake stuff
edgao Feb 14, 2024
000e461
fixups for snowflake timezone migration stuff
edgao Feb 22, 2024
37bfa77
fix build
edgao Feb 23, 2024
5a380b3
format
edgao Feb 23, 2024
e4e467b
also skip for overwrite sync mode
edgao Feb 26, 2024
4ac67b9
fix compilation errors post rebase
gisripa Mar 1, 2024
927b3d8
fix compilation in test
gisripa Mar 1, 2024
d811907
pr comments
gisripa Mar 1, 2024
f5c9e0e
version bump logistics
gisripa Mar 1, 2024
c109d59
uppercase rawNamespace for test
gisripa Mar 1, 2024
0d9d66d
skip minstamp for overwrite
gisripa Mar 4, 2024
6a4ec88
fmt
gisripa Mar 4, 2024
226dde4
add explicit date format
gisripa Mar 4, 2024
c7b8bff
another nit tz func
gisripa Mar 4, 2024
0dad9c6
add tests??
edgao Mar 5, 2024
f4657b1
2024 >.>
edgao Mar 5, 2024
08b77ee
add test for existing local tz final table records
edgao Mar 5, 2024
8bb1803
delete migration
edgao Mar 5, 2024
1fece83
tsadd dance + fmt
gisripa Mar 5, 2024
dba28d3
test fixes
gisripa Mar 5, 2024
93531b2
try fixing test
edgao Mar 5, 2024
c5898b4
fmt
gisripa Mar 5, 2024
575d340
fix tests for real
gisripa Mar 5, 2024
839df58
fix append mode
gisripa Mar 5, 2024
e3eeac7
add append mode tests
edgao Mar 5, 2024
5ced57c
move timestamp crap into min/max call
edgao Mar 5, 2024
a067fc5
move timestamp fiddling back out of cte for max timestamp
edgao Mar 5, 2024
840116d
format
edgao Mar 5, 2024
a46a655
stop filtering on extractedAt in commitRawTable
edgao Mar 5, 2024
075cf8a
migration fixtures with mixed TZs
gisripa Mar 6, 2024
61b2d99
minor fixes
gisripa Mar 6, 2024
f3c9b3b
remove commitDestinationState temporarily
gisripa Mar 6, 2024
6902830
Revert "remove commitDestinationState temporarily"
edgao Mar 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
uppercase rawNamespace for test
  • Loading branch information
gisripa committed Mar 6, 2024
commit c109d59fbfb0e551a1c2354caab37e96d32eb5d1
Original file line number Diff line number Diff line change
@@ -72,7 +72,7 @@ protected SnowflakeSqlGenerator getSqlGenerator() {

@Override
protected SnowflakeDestinationHandler getDestinationHandler() {
return new SnowflakeDestinationHandler(databaseName, database, namespace);
return new SnowflakeDestinationHandler(databaseName, database, namespace.toUpperCase());
}

@Override