Java destinations: Move old dv2 migrators to new framework #35597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
edgao
force-pushed
the
edgao/weird_migrators_migration
branch
from
6f48ba2 to
f8e10db
Compare
edgao
force-pushed
the
edgao/snowflake_timezone_migration
branch
from
d8d91bb to
9b75a37
Compare
edgao
force-pushed
the
edgao/weird_migrators_migration
branch
from
b6368f7 to
03b098c
Compare
edgao
force-pushed
the
edgao/snowflake_timezone_migration
branch
from
9b75a37 to
451dead
Compare
edgao
force-pushed
the
edgao/weird_migrators_migration
branch
from
03b098c to
206af3f
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
edgao
force-pushed
the
edgao/snowflake_timezone_migration
branch
from
451dead to
dcf7289
Compare
edgao
force-pushed
the
edgao/weird_migrators_migration
branch
from
206af3f to
fab2205
Compare
edgao
force-pushed
the
edgao/snowflake_timezone_migration
branch
from
dcf7289 to
6d327e3
Compare
edgao
force-pushed
the
edgao/weird_migrators_migration
branch
from
fab2205 to
6069cd1
Compare
edgao
force-pushed
the
edgao/snowflake_timezone_migration
branch
from
6d327e3 to
48521d3
Compare
edgao
force-pushed
the
edgao/weird_migrators_migration
branch
from
6069cd1 to
5a2774a
Compare
edgao
force-pushed
the
edgao/snowflake_timezone_migration
branch
from
48521d3 to
c31ad5a
Compare
edgao
force-pushed
the
edgao/weird_migrators_migration
branch
from
5a2774a to
501b2d2
Compare
edgao
force-pushed
the
edgao/snowflake_timezone_migration
branch
from
c31ad5a to
dd81885
Compare
edgao
force-pushed
the
edgao/weird_migrators_migration
branch
5 times, most recently
from
6dbcb6b to
61e34fc
Compare
edgao
changed the title
gisripa
force-pushed
the
edgao/snowflake_timezone_migration
branch
4 times, most recently
from
0def1a5 to
016c9cb
Compare
edgao
force-pushed
the
edgao/snowflake_timezone_migration
branch
from
2681c30 to
34e3b23
Compare
gisripa
force-pushed
the
edgao/snowflake_timezone_migration
branch
from
d5c2bce to
61b2d99
Compare
edgao
force-pushed
the
edgao/weird_migrators_migration
branch
from
61e34fc to
7340a4a
Compare
|
This should probably be closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
my previous stack of PRs (starting with #35376) left the V1V2Migrator and V2TableMigrators as weird special things. This PR moves them to use the new Migration interface. See #35644 for destination-snowflake; I'll implement the rest after my other PRs get merged.
... given that I'm going PTO in <2 weeks, it might make sense to hold off on this for now. But wanted to get some eyes on this early, since it's probably a good idea? (i.e. we're no longer calling migrateIfNecessary on every stream/sync)