-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
source-woocommerce: ensure inline schemas, updated cdk, poetry, generate builder manifest #37289
source-woocommerce: ensure inline schemas, updated cdk, poetry, generate builder manifest #37289
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
airbyte-integrations/connectors/source-woocommerce/source_woocommerce/schemas/coupons.json
Outdated
Show resolved
Hide resolved
| 0.2.0 | 2022-11-30 | [19903](https://github.com/airbytehq/airbyte/pull/19903) | Migrate to low-code; Certification to Beta | | ||
| 0.1.1 | 2021-11-08 | [7499](https://github.com/airbytehq/airbyte/pull/7499) | Remove base-python dependencies | | ||
| 0.1.0 | 2021-09-09 | [5955](https://github.com/airbytehq/airbyte/pull/5955) | Initial Release. Source WooCommerce | | ||
| 0.2.7 | 2024-05-14 | [37289](https://github.com/airbytehq/airbyte/pull/37289) | Updating to 0.88.0 CDK | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we published previous versions of the connector related to this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so. But the number changes came from the automated scripts run by Brian.
|
||
[tool.poetry.dependencies] | ||
python = "^3.9,<3.12" | ||
airbyte-cdk = "0.88" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we hardcode from the minor version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxi297 told me it was better to keep the connector stable in case of future changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
schema = stream.json_schema | ||
if not schema: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to move those changes to another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this change so the PR can run clean CATs, othrewise CI wouldn't pass. Is it OK to keep them?
fix typo in Readme Co-authored-by: Serhii Lazebnyi <[email protected]>
Closed to avoid conflicts with Brian's work. |
This was created from a set of automated scripts. In each case, not every update was needed for every connector, but overall here is what happened:
auto-schema update -s all description
: added descriptions to json and inline schemasconnector-code migrate_to_yaml -c all --type source
: migrates json schemas to connectors with a manifestairbyte-ci connectors --name=<all modified connectors from above> migrate_to_base_image
: makes sure that each is using a base docker image and updates docsairbyte-ci connectors --name=<all modified connectors from above> migrate-to-poetry
: moves connectors not already using poetry to do so and updates documentationairbyte-ci connectors --name=<all modified connectors from above> up_to_date
: updated the CDK to newer (0.88.0) versionThe version number and changelogs were also bumped using the
connector-code pulls
command.Additionally a few changes were made on top of the above changes: