Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌟 [destination-pinecone]: Add support for Pinecone Serverless #37601

Conversation

rschwabco
Copy link
Contributor

@rschwabco rschwabco commented Apr 25, 2024

What

Updating the Pinecone connector to use Pinecone's latest Python SDK version and support serverless.

How

Update the SDK version, initialization method and deletion of data for serverless (using list instead of delete by metadata).

Review guide

  1. airbyte/airbyte-integrations/connectors/destination-pinecone/destination_pinecone/indexer.py
  2. airbyte/airbyte-integrations/connectors/destination-pinecone/destination_pinecone/pinecone_integration_test.py
  3. airbyte/airbyte-integrations/connectors/destination-pinecone/destination_pinecone/pyproject.toml
  4. airbyte/airbyte-integrations/connectors/destination-pinecone/destination_pinecone/poetry.lock

User Impact

  • Users should not be affected, this should only add support for serverless indexes.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@rschwabco rschwabco requested a review from a team as a code owner April 25, 2024 23:35
Copy link

vercel bot commented Apr 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 5:08pm

@rschwabco rschwabco marked this pull request as draft April 25, 2024 23:36
@aaronsteers aaronsteers marked this pull request as ready for review April 26, 2024 04:55
@aaronsteers

This comment was marked as outdated.

Copy link
Contributor

github-actions bot commented Apr 26, 2024

PR test job started... Check job output.

✅ Tests passed. 📎

@aaronsteers aaronsteers self-requested a review April 26, 2024 05:10
@aaronsteers aaronsteers changed the title updating to serverless Feat(destination-pinecode): Add support for Pinecone Serverless Apr 26, 2024
@aaronsteers
Copy link
Collaborator

aaronsteers commented Apr 26, 2024

/format-fix (format check is flaky right now, so this is a workaround)

Format-fix job started... Check job output.

❌ Job failed.

@marcosmarxm marcosmarxm changed the title Feat(destination-pinecode): Add support for Pinecone Serverless 🌟 [destination-pinecone]: Add support for Pinecone Serverless Apr 29, 2024
@aaronsteers
Copy link
Collaborator

Merged in #37756. Thank you @rschwabco !

@aaronsteers aaronsteers closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants