🌟 [destination-pinecone]: Add support for Pinecone Serverless #37756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
bindipankhudi
changed the base branch from
master
to
rschwabco/feature/pinecone-connector-serverless
bindipankhudi
changed the base branch from
rschwabco/feature/pinecone-connector-serverless
to
master
…pport-for-pinecone-serverless
2 tasks
aaronsteers
requested changes
May 6, 2024
airbyte-integrations/connectors/destination-pinecone/destination_pinecone/indexer.py
Outdated
Show resolved
Hide resolved
...-integrations/connectors/destination-pinecone/integration_tests/pinecone_integration_test.py
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/destination-pinecone/metadata.yaml
Outdated
Show resolved
Hide resolved
airbyte-integrations/connectors/destination-pinecone/pyproject.toml
Outdated
Show resolved
Hide resolved
…on_tests/pinecone_integration_test.py
Co-authored-by: Aaron ("AJ") Steers <[email protected]>
…yaml
updating to 0.1.0
Co-authored-by: Aaron ("AJ") Steers <[email protected]>
….toml
updating to 0.1.0
Co-authored-by: Aaron ("AJ") Steers <[email protected]>
updating to 0.1.0
Co-authored-by: Aaron ("AJ") Steers <[email protected]>
All suggested changes have been addressed. |
aaronsteers
approved these changes
May 6, 2024
airbyte-integrations/connectors/destination-pinecone/destination_pinecone/indexer.py
Show resolved
Hide resolved
aaronsteers
changed the title
|
Merging with one failing check for unit tests (87% coverage, vs target 90%). If this alarms us, we'll need to create a follow-on PR to address. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #37601
Authored by: @rschwabco
What
Updating the Pinecone connector to use Pinecone's latest Python SDK version and support serverless.
How
Update the SDK version, initialization method and deletion of data for serverless (using list instead of delete by metadata).
Review guide
airbyte/airbyte-integrations/connectors/destination-pinecone/destination_pinecone/indexer.pyairbyte/airbyte-integrations/connectors/destination-pinecone/destination_pinecone/pinecone_integration_test.pyairbyte/airbyte-integrations/connectors/destination-pinecone/destination_pinecone/pyproject.tomlairbyte/airbyte-integrations/connectors/destination-pinecone/destination_pinecone/poetry.lockUser Impact
Can this PR be safely reverted and rolled back?