Destinations: Refreshes: CDK updates #38067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
3 times, most recently
from
9f8ae69 to
50c1e4b
Compare
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
50c1e4b to
e857ce6
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
edgao
commented
May 8, 2024
| DestinationSyncMode.APPEND_DEDUP, | ||
| primaryKey, | ||
| Optional.of(cursor), | ||
| COLUMNS | ||
| COLUMNS, | ||
| 0, |
There was a problem hiding this comment.
maybe we should use nonzero generation id, so that tests are slightly more stringent?
edgao
commented
May 8, 2024
| DestinationSyncMode.OVERWRITE, | ||
| mock(), | ||
| mock(), | ||
| mock() | ||
| mock(), | ||
| 0, |
There was a problem hiding this comment.
for a later stacked PR: I think we need to add generation-related logic into DefaultTyperDeduper? so we'll want more test cases in this class...
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
e857ce6 to
982948e
Compare
edgao
commented
May 8, 2024
| import java.util.* | ||
| import kotlin.collections.LinkedHashMap | ||
|
|
||
| data class StreamConfig( | ||
| val id: StreamId, | ||
| val syncMode: SyncMode, |
There was a problem hiding this comment.
this is the source sync mode, which we should never look at. Delete it.
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
6 times, most recently
from
6839b3f to
d361d45
Compare
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
3 times, most recently
from
a3bb96c to
eca8010
Compare
edgao
force-pushed
the
edgao/catalog_parser_improvements
branch
from
7aff2a5 to
2047aec
Compare
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
eca8010 to
7058132
Compare
edgao
force-pushed
the
edgao/catalog_parser_improvements
branch
from
2047aec to
2f4b6ac
Compare
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
7058132 to
1306644
Compare
2 tasks
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
9dd4a9d to
ea03c9b
Compare
edgao
force-pushed
the
edgao/bigquery_more_cdk_bump
branch
from
eed66f8 to
da3e829
Compare
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
ea03c9b to
f00bab9
Compare
edgao
force-pushed
the
edgao/bigquery_more_cdk_bump
branch
from
da3e829 to
39971f7
Compare
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
f00bab9 to
0850f44
Compare
edgao
force-pushed
the
edgao/bigquery_more_cdk_bump
branch
from
39971f7 to
292aa89
Compare
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
0850f44 to
e7f351c
Compare
edgao
force-pushed
the
edgao/bigquery_more_cdk_bump
branch
from
292aa89 to
bc71af7
Compare
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
e7f351c to
5f84378
Compare
gisripa
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
5f84378 to
8234563
Compare
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
8234563 to
21ed84f
Compare
gisripa
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
21ed84f to
12be697
Compare
2 tasks
gisripa
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
12be697 to
47f9fff
Compare
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
47f9fff to
b3e1c66
Compare
gisripa
approved these changes
Jun 13, 2024
|
yep, I actually pushed that just now (platform released 0.63.0 with full refreshes support) |
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
b3e1c66 to
04d1404
Compare
gisripa
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
04d1404 to
c43df8c
Compare
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
c43df8c to
04d1404
Compare
stephane-airbyte
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
04d1404 to
b116855
Compare
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
b116855 to
b3d7092
Compare
edgao
force-pushed
the
destinations_refreshes_cdk_changes
branch
from
b3d7092 to
10a1cbb
Compare
|
/publish-java-cdk
|
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/airbytehq/airbyte-internal-issues/issues/7606
These are the changes that break platform compatibility. We shouldn't release this until platform is ready for it, and we can turn on the
supportsRefreshesmetadata in destinations.