Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3V2: Increase memory overhead ratio #48812

Conversation

johnny-schmidt
Copy link
Contributor

What

This seems to keep the big avro/parquet syncs from grinding to a halt on high-work streams.

@johnny-schmidt johnny-schmidt requested a review from a team as a code owner December 5, 2024 00:01
Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 7:54pm

Copy link
Contributor

@tryangul tryangul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to make the default higher in general?

Also is this mixing concerns? E.g. are we indirectly trying to account for the memory usage by the writer (process records) in the input queues?

@johnny-schmidt
Copy link
Contributor Author

Do we want to make the default higher in general?

Also is this mixing concerns? E.g. are we indirectly trying to account for the memory usage by the writer (process records) in the input queues?

I mean, we're trying to get the message queues to respect the contract that they only use approximately 20% of memory. (Tho arguably that does mix concerns.

Maybe these message queues just need to be aggressively limited, like if there's no work to do downstream we're just wasting effort clearing stdin.

@johnny-schmidt johnny-schmidt force-pushed the jschmidt/s3v2/fix-backpressure-by-increasing-memory-ratio branch from 7a32fa1 to c6b4783 Compare December 17, 2024 19:43
@johnny-schmidt johnny-schmidt enabled auto-merge (squash) December 17, 2024 19:43
@johnny-schmidt johnny-schmidt merged commit 9bff367 into master Dec 17, 2024
35 checks passed
@johnny-schmidt johnny-schmidt deleted the jschmidt/s3v2/fix-backpressure-by-increasing-memory-ratio branch December 17, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants