Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3V2: Increase memory overhead ratio #48812

Merged
merged 1 commit into from
Dec 17, 2024
Merged

S3V2: Increase memory overhead ratio #48812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/destination-s3-v2/metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ data:
connectorSubtype: file
connectorType: destination
definitionId: d6116991-e809-4c7c-ae09-c64712df5b66
dockerImageTag: 0.3.2
dockerImageTag: 0.3.3
dockerRepository: airbyte/destination-s3-v2
githubIssueLabel: destination-s3-v2
icon: s3.svg
Expand Down
5 changes: 3 additions & 2 deletions airbyte-integrations/connectors/destination-s3-v2/src/main/kotlin/S3V2Configuration.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ data class S3V2Configuration<T : OutputStream>(
override val objectStorageUploadConfiguration: ObjectStorageUploadConfiguration =
ObjectStorageUploadConfiguration(),
override val recordBatchSizeBytes: Long,
override val numProcessRecordsWorkers: Int = 2
override val numProcessRecordsWorkers: Int = 2,
override val estimatedRecordMemoryOverheadRatio: Double = 5.0
) :
DestinationConfiguration(),
AWSAccessKeyConfigurationProvider,
Expand All @@ -65,7 +66,7 @@ class S3V2ConfigurationFactory(
objectStoragePathConfiguration = pojo.toObjectStoragePathConfiguration(),
objectStorageFormatConfiguration = pojo.toObjectStorageFormatConfiguration(),
objectStorageCompressionConfiguration = pojo.toCompressionConfiguration(),
recordBatchSizeBytes = recordBatchSizeBytes
recordBatchSizeBytes = recordBatchSizeBytes,
)
}
}
Expand Down
Loading