Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(source-pardot): 23 new streams, fixed auth flow #49424

Merged
merged 9 commits into from
Dec 17, 2024

Conversation

ChristoGrab
Copy link
Contributor

@ChristoGrab ChristoGrab commented Dec 12, 2024

What

This PR is forked from the contribution of the awesome @NAjustin, who revamped the broken auth flow in source Pardot as well as adding a whopping 23 new streams. See his original PR description below:

  • Fix authentication
  • Migrate all existing streams to Pardot v5 API (except email_clicks which is only available in v4)
  • Re-implement incremental syncs for existing streams where possible
  • Add 23 new streams from the v5 API (folders, emails, engagement_studio_programs, folder_contents, forms, form_fields, form_handlers, form_handler_fields, landing_pages, layout_templates, lifecycle_stages, lifecycle_histories, list_emails, opportunities, tags, tracker_domains, visitor_page_views)
  • Add additional configuration options to better handle large accounts (e.g. adjustable split-up windows, page size)
  • Align to Pardot-recommended sort/filter/pagination conventions to avoid timeouts (based on Pardot support case #469072278)
  • Update connector documentation

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 3:34pm

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/pardot labels Dec 12, 2024
@ChristoGrab ChristoGrab marked this pull request as ready for review December 12, 2024 20:28
@ChristoGrab ChristoGrab requested review from natikgadzhi, DanyloGL and a team December 12, 2024 20:28
@octavia-squidington-iv octavia-squidington-iv requested a review from a team December 12, 2024 20:29
@justbeez
Copy link
Contributor

@ChristoGrab I made a PR to your branch with an updated docs page to align with the changes. You can see that in #49461 (I pulled from your current branch, so should be a clean merge)

@ChristoGrab
Copy link
Contributor Author

ChristoGrab commented Dec 13, 2024

@natikgadzhi Justin added updated docs this morning; they're already merged into this branch, just need an approval and force-merge to ignore the failing QA test (CI wants CATs enabled)

@natikgadzhi natikgadzhi merged commit b7e25c9 into master Dec 17, 2024
34 of 37 checks passed
@natikgadzhi natikgadzhi deleted the christo/pardot-v5-justin branch December 17, 2024 16:21
@natikgadzhi
Copy link
Contributor

Once this ships, @DanyloGL can you poke @NAjustin to verify it works on Cloud? :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/pardot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants