Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Pardot: Update documentation to align with latest connector version #49461

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Source Pardot: Update documentation to align with latest connector version #49461

merged 1 commit into from
Dec 13, 2024

Conversation

justbeez
Copy link
Contributor

@justbeez justbeez commented Dec 13, 2024 •
edited
Loading

Source Pardot: Update documentation to align with latest connector version

What

Update Pardot source docs to align with in-progress PR version (#49424) of Pardot connector

How

  • documented new optional config properties
  • added streams to the list, including sync modes and docs links
  • noted the one stream that still uses the v4 API
  • tried to bring the docs in line with the styles of other connectors (e.g. HubSpot, Salesforce)
  • added noted on performance tweaking based on account size, which was one of the reasons for this connector update

Review guide

This should align with the connector

User Impact

It should actually make sense :)

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@vercel Vercel
Copy link

vercel bot commented Dec 13, 2024

@justbeez is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Dec 13, 2024
@justbeez justbeez temporarily deployed to community-ci-auto December 13, 2024 14:36 — with GitHub Actions Inactive
@justbeez justbeez temporarily deployed to community-ci-auto December 13, 2024 14:37 — with GitHub Actions Inactive
@justbeez justbeez mentioned this pull request Dec 13, 2024
Merged
2 tasks
ChristoGrab
ChristoGrab approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@ChristoGrab ChristoGrab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fresh docs @justbeez! Approving and merging so we can push everything up to main

@ChristoGrab ChristoGrab merged commit 4897610 into airbytehq:christo/pardot-v5-justin Dec 13, 2024
25 of 30 checks passed
@justbeez justbeez deleted the justbeez/source-pardot-docs-update branch December 13, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristoGrab ChristoGrab ChristoGrab approved these changes

Assignees
No one assigned
Labels
area/documentation Improvements or additions to documentation community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justbeez @ChristoGrab @octavia-squidington-iii