base-images: release a base image for our java connectors #49831
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
alafanechere
force-pushed
the
augustin/12-17-base-images_declare_a_base_image_for_our_java_connectors
branch
from
709f1b1 to
10dc398
Compare
alafanechere
changed the title
| RUN yum update -y --security | ||
| RUN yum install -y tar openssl findutils |
There was a problem hiding this comment.
I know this is just the example, but looking into the code further down in this PR, it looks like we're following what this example does.
We want to limit the number of RUN calls in our image creation process. Each RUNwill create a new layer and further increase the size of our base image.
You can see on the platform side how we've collapsed multiple RUN calls into a single call to reduce our base image size.
There was a problem hiding this comment.
@colesnodgrass I can definitely bundle these three commands into one. Thank you for the suggestion.
There was a problem hiding this comment.
Thank you for the tips @colesnodgrass . 50mb saved 👍
alafanechere
force-pushed
the
augustin/12-17-base-images_declare_a_base_image_for_our_java_connectors
branch
from
10dc398 to
6bd024b
Compare
|
|
||
|
|
||
| class AirbyteJavaConnectorBaseImage(bases.AirbyteConnectorBaseImage): | ||
| # TODO: remove this once we want to build the base image with the airbyte user. |
There was a problem hiding this comment.
This I expect mimics the current setup?
There was a problem hiding this comment.
Yes the current user is root. The parent class sets it to airbyte, so I override the USER with root to keep v1 expected user be root.
alafanechere
force-pushed
the
augustin/12-17-base-images_declare_a_base_image_for_our_java_connectors
branch
from
6bd024b to
569f2df
Compare
| repository: Final[str] = "airbyte/java-connector-base" | ||
|
|
||
| DD_AGENT_JAR_URL: Final[str] = "https://dtdg.co/latest-java-tracer" | ||
| BASE_SCRIPT_URL = "https://raw.githubusercontent.com/airbytehq/airbyte/6d8a3a2bc4f4ca79f10164447a90fdce5c9ad6f9/airbyte-integrations/bases/base/base.sh" |
There was a problem hiding this comment.
consider lifting the git commit sha to a dedicated constant
alafanechere
deleted the
augustin/12-17-base-images_declare_a_base_image_for_our_java_connectors
branch
What
Relates to https://github.com/airbytehq/airbyte-internal-issues/issues/11151
Declare a base image for our java connectors by copying the build logic currently declared in
airbyte-ciherePrelease it to DockerHub:
airbyte/java-connector-base:1.0.0-rc.1