airbyte-ci: use the base image to build java connectors #49832
Merged
+39
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
alafanechere
force-pushed
the
augustin/12-17-airbyte-ci_use_the_base_image_to_build_java_connectors
branch
2 times, most recently
from
5f76a08 to
0ec995a
Compare
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
removed
area/connectors
postamar
approved these changes
Dec 17, 2024
|
|
||
| return wrapper | ||
|
|
||
| return decorator |
|
|
||
| connector_container = ( | ||
| base.with_workdir("/airbyte") | ||
| .with_env_variable("APPLICATION", application) | ||
| .with_mounted_directory("built_artifacts", build_stage.directory("/airbyte")) | ||
| .with_exec(sh_dash_c(["mv built_artifacts/* ."])) | ||
| .with_entrypoint(entrypoint) |
There was a problem hiding this comment.
just checking: this is safe to remove? I don't actually know
There was a problem hiding this comment.
Yes it it, I set it in the base image. And if the base image code path is not taken I added the entrypoint explicitely on line 177 and 183
alafanechere
force-pushed
the
augustin/12-17-base-images_declare_a_base_image_for_our_java_connectors
branch
from
10dc398 to
6bd024b
Compare
alafanechere
force-pushed
the
augustin/12-17-airbyte-ci_use_the_base_image_to_build_java_connectors
branch
from
1c050a0 to
2c15502
Compare
alafanechere
force-pushed
the
augustin/12-17-base-images_declare_a_base_image_for_our_java_connectors
branch
from
6bd024b to
569f2df
Compare
alafanechere
force-pushed
the
augustin/12-17-airbyte-ci_use_the_base_image_to_build_java_connectors
branch
from
2c15502 to
de5b7b7
Compare
Base automatically changed from
augustin/12-17-base-images_declare_a_base_image_for_our_java_connectors
to
master
December 17, 2024 17:30
alafanechere
force-pushed
the
augustin/12-17-airbyte-ci_use_the_base_image_to_build_java_connectors
branch
from
de5b7b7 to
b647e43
Compare
alafanechere
deleted the
augustin/12-17-airbyte-ci_use_the_base_image_to_build_java_connectors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes https://github.com/airbytehq/airbyte-internal-issues/issues/11151
We started publishing base image for our java connectors in #49831 .
To make this base image used we should enable java connectors to express the base image they want to use in
metadata.yamllike we do for java connectors.This PR updates
airbyte-cito build java connectors from the base image declared inmetadata.yaml.It also marks the original build code paths as deprecated.
Connector testing
source-postgrestests on this branch. 🎉source-postgresversion if maintainers of this connectors want to test it out on Airbyte Cloud.