Add support for minio copy workflow though API #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craddm
reviewed
Nov 4, 2025
Comment on lines
+15
to
+18
| volumes: | ||
| - name: workflow-data-ingress | ||
| persistentVolumeClaim: | ||
| claimName: workflow-data-ingress |
There was a problem hiding this comment.
Make this parameters rather than a pre-set name
craddm
reviewed
Nov 4, 2025
Comment on lines
+125
to
+137
| workflow_data_pvc = PersistentVolumeClaim( | ||
| "workflow-data-pvc", | ||
| metadata=ObjectMetaArgs( | ||
| name="workflow-data-ingress", | ||
| namespace=argo_workflows_ns.metadata.name, | ||
| ), | ||
| spec=PersistentVolumeClaimSpecArgs( | ||
| access_modes=["ReadWriteMany"], | ||
| storage_class_name="fridge", | ||
| resources=VolumeResourceRequirementsArgs(requests={"storage": "2Gi"}), | ||
| ), | ||
| ) | ||
|
|
There was a problem hiding this comment.
I don't think we want to be doing this here. This should be interfacing with the PVC defined in #140
craddm
requested changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an API endpoint of
/object/move/$FILEwhich triggers aminio-copyworkflow specifying the ingress bucket and file to be copied.Copies the data to a PVC which is mounted into the workflow pod.
Authentication with minio is currently handled by the existing
argo-artifacts-miniosecret that exists in the pulumi (currently minio admin).Test workflow result: