Root event date #125
Merged
Root event date #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgreenbury
reviewed
Oct 13, 2023
trustchain-cli/src/bin/main.rs
Outdated
| // Can unwrap as already verified above. | ||
| .unwrap(); | ||
| let chain = | ||
| TrustchainAPI::verify(issuer, root_event_time.into(), &verifier) |
There was a problem hiding this comment.
Remove into() (clippy)
sgreenbury
reviewed
Oct 13, 2023
trustchain-core/src/utils.rs
Outdated
Comment on lines
105
to
109
| let mut did = String::from_str("did:").unwrap(); | ||
| did.push_str(method); | ||
| did.push_str(":"); | ||
| did.push_str(did_suffix); | ||
| did |
There was a problem hiding this comment.
Suggested change
| let mut did = String::from_str("did:").unwrap(); | |
| did.push_str(method); | |
| did.push_str(":"); | |
| did.push_str(did_suffix); | |
| did | |
| format!("did:{method}:{did_suffix}") |
sgreenbury
reviewed
Oct 13, 2023
sgreenbury
reviewed
Oct 13, 2023
trustchain-http/src/errors.rs
Outdated
| @@ -108,6 +118,7 @@ impl IntoResponse for TrustchainHTTPError { | |||
| err @ TrustchainHTTPError::NoCredentialIssuer => { | |||
| (StatusCode::BAD_REQUEST, err.to_string()) | |||
| } | |||
| err @ TrustchainHTTPError::RootError(_) => (StatusCode::BAD_REQUEST, err.to_string()), | |||
sgreenbury
reviewed
Oct 13, 2023
trustchain-http/src/root.rs
Outdated
| debug!("Getting root candidates for {0}", date); | ||
|
|
||
| // Return the cached vector of root DID candidates, if available. | ||
| if root_candidates.lock().unwrap().contains_key(&date) { |
There was a problem hiding this comment.
Perhaps create a single lock to use throughout function?
sgreenbury
reviewed
Oct 13, 2023
sgreenbury
reviewed
Oct 13, 2023
sgreenbury
reviewed
Oct 13, 2023
trustchain-ion/src/verifier.rs
Outdated
| @@ -134,20 +131,20 @@ where | |||
|
|
|||
| /// Gets RPC client. | |||
| fn rpc_client(&self) -> &bitcoincore_rpc::Client { | |||
| self.rpc_client.as_ref().unwrap() | |||
| self.rpc_client.as_ref().unwrap() // TODO: handle failure here. | |||
There was a problem hiding this comment.
I think this is ok as the API has constrained it to exist here
sgreenbury
reviewed
Oct 13, 2023
trustchain-ion/src/verifier.rs
Outdated
| } | ||
|
|
||
| /// Gets IPFS client. | ||
| fn ipfs_client(&self) -> &IpfsClient { | ||
| self.ipfs_client.as_ref().unwrap() | ||
| self.ipfs_client.as_ref().unwrap() // TODO: handle failure here. |
sgreenbury
reviewed
Oct 13, 2023
sgreenbury
reviewed
Oct 13, 2023
sgreenbury
reviewed
Oct 13, 2023
sgreenbury
reviewed
Oct 13, 2023
sgreenbury
reviewed
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server-side code to support trustchain-mobile #26.
Adds an HTTP endpoint for getting candidate root DIDs (each with a corresponding Bitcoin transaction ID) that were timestamped on a given a calendar date.
Does not address the related #130.