Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root event date #125

Merged
merged 23 commits into from
Oct 13, 2023

Improve HTTP status codes on root error

07ab3c3
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Root event date #125

Improve HTTP status codes on root error
07ab3c3
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Oct 13, 2023 in 1s

clippy

2 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 2
Note 0
Help 0

Versions

  • rustc 1.72.1 (d5c2e9c34 2023-09-13)
  • cargo 1.72.1 (103a7ff2e 2023-08-15)
  • clippy 0.1.72 (d5c2e9c 2023-09-13)

Annotations

Check warning on line 369 in trustchain-ion/src/utils.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

`if` chain can be rewritten with `match`

warning: `if` chain can be rewritten with `match`
   --> trustchain-ion/src/utils.rs:365:9
    |
365 | /         if current_unixtime as i64 > target_unixtime {
366 | |             end_height = current_height; // TODO CHECK: original script has: current_height - 1;
367 | |         } else if (current_unixtime as i64) < target_unixtime {
368 | |             start_height = current_height; // TODO CHECK: original script has: current_height + 1;
369 | |         }
    | |_________^
    |
    = help: consider rewriting the `if` chain to use `cmp` and `match`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_chain
    = note: `#[warn(clippy::comparison_chain)]` on by default

Check warning on line 9 in trustchain-ion/src/utils.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `StreamExt`

warning: unused import: `StreamExt`
 --> trustchain-ion/src/utils.rs:9:15
  |
9 | use futures::{StreamExt, TryStreamExt};
  |               ^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default