-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support box plot in addition to violin plot #208
Conversation
Thanks, looks good! I would prefer to add a second boolean This would mean making the boxplots narrower at least in the case when |
An alternative would be to have a vector-valued argument, |
This figure below shows the boxplots when the width is always 0.25 |
That could be nice. It would make the code simpler when there are multiple choices. For these two (violin and box), I prefer the current solution as it is quite simple |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks! Can address the colour thing in a separate PR if necessary
btw I hope it goes without saying but you don't need to add your email when adding yourself as a ctb, it's entirely up to you |
Ahh yes. I did not pay attention on that, I just copy-pasted my information. I would rather remove my email, but I can do that if I do another PR on the coloring |
Removed 35f3002 |
Related to this issue: #207
This PR adds support for box plot. In addition to violin plot, user can also choose to visualize the data with box plot, This can be done by specifying
layout = "box
. I tried to follow your coding style, and this should be minimum modifications to get the support.Here are examples on functionality
-Tuomas