Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versioneer #354

Merged
merged 10 commits into from
Apr 1, 2024

Conversation

xiki-tempula
Copy link
Collaborator

@xiki-tempula xiki-tempula commented Mar 31, 2024

Fix #352, builds on top of #351

@xiki-tempula xiki-tempula linked an issue Mar 31, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.82%. Comparing base (160a012) to head (008db33).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #354   +/-   ##
=======================================
  Coverage   98.82%   98.82%           
=======================================
  Files          28       28           
  Lines        1873     1873           
  Branches      405      405           
=======================================
  Hits         1851     1851           
  Misses          2        2           
  Partials       20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiki-tempula xiki-tempula requested a review from orbeckst March 31, 2024 13:09
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does CI work with Py 3.12 again? Can you re-enable (was disabled with merged PR #351 )

@orbeckst orbeckst mentioned this pull request Apr 1, 2024
@orbeckst orbeckst self-assigned this Apr 1, 2024
@orbeckst orbeckst enabled auto-merge (squash) April 1, 2024 08:26
@orbeckst orbeckst merged commit 3cf7c25 into master Apr 1, 2024
11 checks passed
@orbeckst orbeckst deleted the 352-alchemlyb-on-py-312-fails-with-versioneer-issues branch April 1, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

alchemlyb on py 3.12 fails with versioneer issues
2 participants