Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockerization, makefile and some fixes #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

svg153
Copy link

@svg153 svg153 commented Jul 22, 2022

We began to use factorial, to control working hours, and we had to enter the hours from the beginning of the year. To do this, we use this tool, and we dockerize it. We also created some common targets. With this, we were able to enter the hours from any environment and person.

So, here is the PR, in case you want to integrate it.

Thank you very much for the tool. All the best.

@alejoar
Copy link
Owner

alejoar commented Jul 28, 2022

Hi @svg153

Thank you for this contribution.

I think I understand the advantages of dockerizing, however I would like to keep the main usage of the app as a standalone/installable binary. I already include binaries for most platforms with each release, have you seen those in the releases page?

In any case, can you please update the Readme file so that anything related to Docker is in a separate section under the current contents? I think that would be enough to merge this.

@svg153
Copy link
Author

svg153 commented Aug 24, 2022

Hi @alejoar.

I updated the branch with these changes:

  • Move Docker information in README.md to a separate section (Docker) under the current content.
  • Create new Makefile targets that use native build.
  • Rename Docker Makefile targets.
  • Add factorialsucks binary created by native build in the root of the repository to .gitignore.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants