Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow incorrect glutin config depth == total bits #8

Merged
merged 2 commits into from
Dec 23, 2023
Merged

Allow incorrect glutin config depth == total bits #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
538b421
Allow incorrect glutin config depth
alexheretic Dec 22, 2023
5c42fac
Update changelog
alexheretic Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# Unreleased
* Allow incorrect OS config depth_size = expected depth_size+stencil_size.
This works around an issue with macos software rendering.

# v0.32.0
* Update _winit_ to `0.29`, _glutin-winit_ to `0.4`, _glutin_ to `0.31`.

Expand Down
4 changes: 3 additions & 1 deletion src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,9 @@ impl<T> Builder<'_, T> {
(!srgb || c.srgb_capable())
&& color_bits == color_total_bits - alpha_bits
&& c.alpha_size() == alpha_bits
&& c.depth_size() == depth_total_bits - stencil_bits
&& (c.depth_size() == depth_total_bits - stencil_bits
// workaround to allow depth_size=32 & stencil_size=8 on macos software renderer
|| c.depth_size() == depth_total_bits)
&& c.stencil_size() == stencil_bits
}));
match best {
Expand Down