Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make cookie handling optional via cargo feature #63

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

mythmon
Copy link
Contributor

@mythmon mythmon commented Jan 11, 2022

Cookie handling includes a dependency that uses the excellent lalrpop parsing library. Unfortunately, lalrpop is also fairly slow to compile. For projects that don't need cookie handling, it's wasted compile time. Making cookie handling in this crate optional helps speed up downstream compile times.

I tested this using cargo-hack:

$ cargo-hack --feature-powerset test

@alexliesenfeld alexliesenfeld mentioned this pull request Jan 11, 2022
@alexliesenfeld
Copy link
Owner

Thanks for providing this PR. Looks good! This will contribute to reducing dependencies as discussed in #46 as well.

@alexliesenfeld alexliesenfeld merged commit eeb4783 into alexliesenfeld:master Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants