Validate rsa private key and certificate content format #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChanDaoH
reviewed
Jul 14, 2020
src/lib/deploy/deploy-support.js
Outdated
| const { green, red } = require('colors'); | ||
| const { processApiParameters } = require('./deploy-support-api'); | ||
| const { getCloudApiClient, getSlsClient, getMnsClient } = require('../client'); | ||
| const {green, red} = require('colors'); |
There was a problem hiding this comment.
我是在 Windows 上用 WebStorm 开发的, 未修改 .eslintrc 的内容, 对 deploy-support.js 使用 .eslintrc 的格式进行格式化的.
测试后发现有没有空格 eslint 都没有报错.
需要我回滚格式化代码的 commit 么?
ChanDaoH
reviewed
Jul 14, 2020
src/lib/deploy/deploy-support.js
Outdated
| let p = path.resolve(__dirname, privateKey); | ||
| // private key is provided by local file | ||
| if (fs.pathExistsSync(p)) { | ||
| certConfig.PrivateKey = fs.readFileSync(p, 'utf-8'); |
There was a problem hiding this comment.
fs.readFileSync(p, 'utf-8') => await fs.readFile(p, 'utf-8')
ChanDaoH
reviewed
Jul 14, 2020
src/lib/deploy/deploy-support.js
Outdated
| let p = path.resolve(__dirname, certificate); | ||
| // certificate is provided by local file | ||
| if (fs.pathExistsSync(p)) { | ||
| certConfig.Certificate = fs.readFileSync(p, 'utf-8'); |
There was a problem hiding this comment.
fs.readFileSync(p, 'utf-8') => await fs.readFile(p, 'utf-8')
ChanDaoH
reviewed
Jul 14, 2020
src/lib/deploy/deploy-support.js
Outdated
| //endregion | ||
|
|
||
| //region validate RSA private key content | ||
| let expectedPrefix = '-----BEGIN RSA PRIVATE KEY-----', expectedSuffix = '-----END RSA PRIVATE KEY-----'; |
ChanDaoH
reviewed
Jul 14, 2020
src/lib/deploy/deploy-support.js
Outdated
| //endregion | ||
|
|
||
| //region validate certificate content | ||
| let expectedPrefix = '-----BEGIN CERTIFICATE-----', expectedSuffix = '-----END CERTIFICATE-----'; |
ChanDaoH
reviewed
Jul 14, 2020
test/fs-extra.test.js
Outdated
| let path = require('path'); | ||
| const expect = require('expect.js'); | ||
|
|
||
| describe('fs-extra module Tests', function () { |
There was a problem hiding this comment.
- 为了确认 fs-extra 的 pathExists 方法对相对路径的支持方式, 目前确认到的情况是需要使用 path.resolve 先对路径进行解析才行.
- 为了确认 fs-extra 的 pathExists 方法对 PrivateKey 以及 Certificate 是硬编码的 PEM 内容时的返回结果.
需要添加注释? 还是删掉这个测试集?
|
🤔 |
1 similar comment
|
🤔 |
|
|
|
Closed as #1146 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #969.