[qtAliceVision] Add new image viewer with Blinn-Phong model #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Clamp negative values in the FloatImageViewer fragment shader before performing the successive `pow`. The result of `pow` is undefined when it is provided negative values. On Linux platforms, it still gives the expected result, but on Windows this leads to issues.
Using sequence player by default may cause errors when `FloatImageViewer` is reactivated.
Source texture should always be initialized to avoid errors (texture binding) when no image is loaded, especially when `FloatImageViewer` is reactivated.
Allows to load and display image (albedo and normal) with a given light direction. Shading is done using Blinn-Phong reflection model.
cbentejac
force-pushed
the
dev/qt6.6_phongImageViewer
branch
from
181bf73
to
2fb8020
Compare
`std::powf` fails to compile with gcc which is not compliant with C++17 when it comes to libstdc++. Additionally, static casts are performed to fix warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new image viewer (Albedo + Normal) with Blinn-Phong model, the
PhongImageViewer.With customizable shader parameters and light direction.
A normal map with two light directions using the new viewer in Meshroom.
Features list
PhongImageViewer.PhongImageViewershader.FloatImageViewerespecially when reactivated.Implementation remarks
This PR is based on the Qt6 migration branch: https://github.com/alicevision/QtAliceVision/tree/dev/qt6.6
Linked to Meshroom PR: alicevision/Meshroom#2444