Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Add and improve multiple UI tools for Photometric stereo #2444

Open
wants to merge 7 commits into
base: dev/qt6.6
Choose a base branch
from

Conversation

gregoire-dl
Copy link
Member

Description

Add the new QtAliceVision 2D viewer with toolbar and a new light direction controller.

A normal map with two light directions.

Add the ability to change the camera-relative light direction in the 3D viewer

Same object with two different light directions using the new light direction controller.

Improve SphereDetection widget in order to handle automatic detection of calibration spheres.

Automatically detected calibration sphere shown with the green circle.

Features list

  • Improve SphereDetection widget in order to handle automatic detection of calibration spheres.
  • Add the new QtAliceVision 2D viewer with Blinn-Phong model with shader control toolbar and light direction toolbar.
  • Add the ability to change the camera-relative light direction in the 3D viewer.

Implementation remarks

This PR is based on the Qt6 migration branch: https://github.com/alicevision/Meshroom/tree/dev/qt6.6
Linked to QtAliceVision PR: alicevision/QtAliceVision#72

@gregoire-dl gregoire-dl added feature new feature (proposed as PR or issue planned by dev) review labels Jun 19, 2024
@gregoire-dl gregoire-dl self-assigned this Jun 19, 2024
Use a single light entity instead of one per camera.
Use directional light instead of point light.
Add camera relative directional light controller.
Default camera up should be accurate and consistent with camera view center.
Default camera up vector is not refresh or checked when default camera view center is set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new feature (proposed as PR or issue planned by dev) review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant